Summary: | C4::Auth should use C4::Context->IsSuperLibrarian() | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Authentication | Assignee: | Bugs List <koha-bugs> |
Status: | NEW --- | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | dpavlin, jonathan.druart |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 20479 | ||
Bug Blocks: |
Description
Katrin Fischer
2018-04-24 11:19:38 UTC
Probably here too, noting that on bug 20515: 297 if ( $flags && $flags->{superlibrarian} == 1 ) { 298 $template->param( CAN_user_circulate => 1 ); No, C4::Context->IsSuperlibrarian tells if the logged in user has the superlibrarian flags. In C4::Auth::get_template_and_user the user is not logged in yet. Actually yes, userenv is set in checkauth which has been called few lines above. Sorry, Jonathan, I don't understand yet. Maybe we can take a look at it together sometime? (In reply to Katrin Fischer from comment #4) > Sorry, Jonathan, I don't understand yet. Maybe we can take a look at it > together sometime? Scratch comment 2, we could replace it instead. |