Summary: | Sort after item type search fails | ||
---|---|---|---|
Product: | Koha | Reporter: | John Yorio <jyorio> |
Component: | Staff interface | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, martin.renvoize, nick, pierre-luc.lapointe |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 19461 | ||
Bug Blocks: | |||
Attachments: |
Bug 20652: Fix result sorting after search on limit only
Bug 20652: Fix result sorting after search on limit only Bug 20652: Fix result sorting after search on limit only |
Description
John Yorio
2018-04-24 14:50:52 UTC
Certainly caused by commit 7d2cb42dceeeb004ab7447fd6beccab5fac37e23 Bug 19461: Add floating toolbar to staff client catalog search results Created attachment 74822 [details] [review] Bug 20652: Fix result sorting after search on limit only 1 chomp was missing, spaces were replaced with %20 This patch adds extra chomps, but it does not hurt Test plan: Advanced Search Choose an Item type (do not enter any other search limits) Search Click on Sort (it doesn't appear to matter what you sort on) Created attachment 75571 [details] [review] Bug 20652: Fix result sorting after search on limit only 1 chomp was missing, spaces were replaced with %20 This patch adds extra chomps, but it does not hurt Test plan: Advanced Search Choose an Item type (do not enter any other search limits) Search Click on Sort (it doesn't appear to matter what you sort on) Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe@inLibro.com> Created attachment 75581 [details] [review] Bug 20652: Fix result sorting after search on limit only 1 chomp was missing, spaces were replaced with %20 This patch adds extra chomps, but it does not hurt Test plan: Advanced Search Choose an Item type (do not enter any other search limits) Search Click on Sort (it doesn't appear to matter what you sort on) Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe@inLibro.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Pushed to master for 18.11. Awesome work all, thank you. This patch has been pushed to 18.05.x, will be in 18.05.01 Pushed to 17.11.x for 17.11.07 |