Bug 20679

Summary: Remove 'rows per page' from reports print layout
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: ReportsAssignee: Jasmine Amohia <jasmineamohia.student>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: fridolin.somers, jesse, martin.renvoize, nick
Version: MainKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 20679: Created syspref to hide/show 'rows per page' from reports print layout
Bug 20679: Removed 'rows per page' from report print layout
Bug 20679: Removed 'rows per page' from report print layout
Bug 20679: Removed 'rows per page' from report print layout

Description Katrin Fischer 2018-04-29 22:10:42 UTC
The print layout of a run report would be a little nicer if the 'rows per page' option would not show.
Comment 1 Jasmine Amohia 2019-01-16 04:06:10 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2019-01-16 15:56:14 UTC
Jasmine, this patch works very well but I don't think it accomplishes what the bug is about. My understanding is that the bug refers specifically to the way the page looks when printed. To hide something in the print view we need to address it using the print stylesheet, intranet-tmpl/prog/css/print.css.

There is a ruleset starting at about line 289 which just lists elements which should be "display:none" when printed. I think all you need to do is add the id of the "Rows per page" form to that list.
Comment 3 Jasmine Amohia 2019-01-16 20:57:56 UTC
Created attachment 84092 [details] [review]
Bug 20679: Removed 'rows per page' from report print layout

Test plan:
1. Create a report or view an existing report
2. Notice that 'Rows per page:' is visible
3. Print report (Ctrl+P)
4. Confirm that on printed report, 'Rows per page:' is no longer visible
Comment 4 Owen Leonard 2019-01-16 23:37:57 UTC
Created attachment 84107 [details] [review]
Bug 20679: Removed 'rows per page' from report print layout

Test plan:
1. Create a report or view an existing report
2. Notice that 'Rows per page:' is visible
3. Print report (Ctrl+P)
4. Confirm that on printed report, 'Rows per page:' is no longer visible

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Katrin Fischer 2019-01-17 06:24:05 UTC
Created attachment 84126 [details] [review]
Bug 20679: Removed 'rows per page' from report print layout

Test plan:
1. Create a report or view an existing report
2. Notice that 'Rows per page:' is visible
3. Print report (Ctrl+P)
4. Confirm that on printed report, 'Rows per page:' is no longer visible

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Nick Clemens 2019-01-28 16:09:43 UTC
Awesome work all!

Pushed to master for 19.05
Comment 7 Martin Renvoize 2019-02-01 13:07:05 UTC
Pushed to 18.11.x for 18.11.03
Comment 8 Jesse Maseto 2019-02-06 18:06:21 UTC
Pushed to 18.05.x for 18.05.09
Comment 9 Fridolin Somers 2019-02-12 15:30:55 UTC
Pushed to 17.11.x for 17.11.15