Summary: | Modify letter template does not render correctly | ||
---|---|---|---|
Product: | Koha | Reporter: | Barton Chittenden <barton> |
Component: | Notices | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 20685: Escape letter template content in textarea
Bug 20685: Escape letter template content in textarea Bug 20685: Escape letter template content in textarea |
Description
Barton Chittenden
2018-04-30 16:32:24 UTC
Created attachment 75022 [details] [review] Bug 20685: Escape letter template content in textarea Test plan: enter the following text into the Email template for 'HOLD_SLIP' in Home › Tools › Notices & Slips › Modify notice <div style='max-width: 4in;'> <h3><<borrowers.surname>>, <<borrowers.firstname>></h3><br /> <<borrowers.streetnumber>> <<borrowers.address>><br /> <<borrowers.address2>><br /> <<borrowers.city>>, <<borrowers.state>> <<borrowers.zipcode>><br /> <br /> <br /> <img src="/cgi-bin/koha/svc/barcode?barcode=<<borrowers.cardnumber>>&type=Industrial2of5¬ext=1"> Edit it again Without this patch you will get: <img src="/cgi-bin/koha/svc/barcode?barcode=<<borrowers.cardnumber>>&type=Industrial2of5¬ext=1"> Created attachment 75039 [details] [review] Bug 20685: Escape letter template content in textarea Test plan: enter the following text into the Email template for 'HOLD_SLIP' in Home › Tools › Notices & Slips › Modify notice <div style='max-width: 4in;'> <h3><<borrowers.surname>>, <<borrowers.firstname>></h3><br /> <<borrowers.streetnumber>> <<borrowers.address>><br /> <<borrowers.address2>><br /> <<borrowers.city>>, <<borrowers.state>> <<borrowers.zipcode>><br /> <br /> <br /> <img src="/cgi-bin/koha/svc/barcode?barcode=<<borrowers.cardnumber>>&type=Industrial2of5¬ext=1"> Edit it again Without this patch you will get: <img src="/cgi-bin/koha/svc/barcode?barcode=<<borrowers.cardnumber>>&type=Industrial2of5¬ext=1"> Signed-off-by: Barton Chittenden <barton@bywatersolutions.com> Created attachment 75046 [details] [review] Bug 20685: Escape letter template content in textarea Test plan: enter the following text into the Email template for 'HOLD_SLIP' in Home › Tools › Notices & Slips › Modify notice <div style='max-width: 4in;'> <h3><<borrowers.surname>>, <<borrowers.firstname>></h3><br /> <<borrowers.streetnumber>> <<borrowers.address>><br /> <<borrowers.address2>><br /> <<borrowers.city>>, <<borrowers.state>> <<borrowers.zipcode>><br /> <br /> <br /> <img src="/cgi-bin/koha/svc/barcode?barcode=<<borrowers.cardnumber>>&type=Industrial2of5¬ext=1"> Edit it again Without this patch you will get: <img src="/cgi-bin/koha/svc/barcode?barcode=<<borrowers.cardnumber>>&type=Industrial2of5¬ext=1"> Signed-off-by: Barton Chittenden <barton@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! Can we get this backported? I'm editing the slip in question, and it's causing all sorts of inconvenience. Pushed to 17.11.x for 17.11.07 |