Summary: | OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled | ||
---|---|---|---|
Product: | Koha | Reporter: | Mason James <mtj> |
Component: | OPAC | Assignee: | Mason James <mtj> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | bob, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18172 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
pic 1
pic 2 Bug 20686: OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled Bug 20686: OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled Bug 20686: OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled |
Description
Mason James
2018-05-01 01:19:45 UTC
Created attachment 74943 [details]
pic 1
Created attachment 74944 [details]
pic 2
Created attachment 74945 [details] [review] Bug 20686: OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled ps: you will need an active and working overdrive account to test this patch 1/ prepare a koha with overdrive sysprefs set and working (OverDriveLibraryID,OverDriveClientKey,OverDriveClientSecret) 2/ set OverDriveCirculation syspref to 'disable' 3/ do an opac search, note the 'Login to OverDrive account' message is incorrectly displayed see pic 1 4/ apply patch 5/ do an opac search, note the 'Login to OverDrive account' message is no longer displayed (good) see pic 2 Created attachment 74963 [details] [review] Bug 20686: OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled ps: you will need an active and working overdrive account to test this patch 1/ prepare a koha with overdrive sysprefs set and working (OverDriveLibraryID,OverDriveClientKey,OverDriveClientSecret) 2/ set OverDriveCirculation syspref to 'disable' 3/ do an opac search, note the 'Login to OverDrive account' message is incorrectly displayed see pic 1 4/ apply patch 5/ do an opac search, note the 'Login to OverDrive account' message is no longer displayed (good) see pic 2 Can confirm that bug is replicable and patch applies and functions as described. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Created attachment 75077 [details] [review] Bug 20686: OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled ps: you will need an active and working overdrive account to test this patch 1/ prepare a koha with overdrive sysprefs set and working (OverDriveLibraryID,OverDriveClientKey,OverDriveClientSecret) 2/ set OverDriveCirculation syspref to 'disable' 3/ do an opac search, note the 'Login to OverDrive account' message is incorrectly displayed see pic 1 4/ apply patch 5/ do an opac search, note the 'Login to OverDrive account' message is no longer displayed (good) see pic 2 Can confirm that bug is replicable and patch applies and functions as described. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 18.05, thanks to everybody involved! |