Summary: | Upload does not show all results when uploading multiple files | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Tools | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, martin.renvoize, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 20695: Fix multiple upload result in tools/upload script
Bug 20695: Fix multiple upload result in tools/upload script Bug 20695: Fix multiple upload result in tools/upload script |
Description
Marcel de Rooy
2018-05-02 12:50:03 UTC
Created attachment 74967 [details] [review] Bug 20695: Fix multiple upload result in tools/upload script Instead of calling UploadedFiles->find only once with $id, we should extract all comma separated id's from the parameter. Test plan: [1] Before this patch, upload two files at once in Tools/Upload. After doing so, you should see only one result reported. But both files should have been uploaded. [2] With this patch, repeat step 1 and see two upload results. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Jonathan: If this one could still reach 18.05 ? Yes of course, if PQA before May 11th Created attachment 75199 [details] [review] Bug 20695: Fix multiple upload result in tools/upload script Instead of calling UploadedFiles->find only once with $id, we should extract all comma separated id's from the parameter. Test plan: [1] Before this patch, upload two files at once in Tools/Upload. After doing so, you should see only one result reported. But both files should have been uploaded. [2] With this patch, repeat step 1 and see two upload results. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Patch applies and functions as described. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> (In reply to Dilan Johnpullé from comment #4) > Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Thx Dilan Created attachment 75234 [details] [review] Bug 20695: Fix multiple upload result in tools/upload script Instead of calling UploadedFiles->find only once with $id, we should extract all comma separated id's from the parameter. Test plan: [1] Before this patch, upload two files at once in Tools/Upload. After doing so, you should see only one result reported. But both files should have been uploaded. [2] With this patch, repeat step 1 and see two upload results. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Patch applies and functions as described. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! |