| Summary: | Home library not displayed on all patron account tabs | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Amit Gupta <amitddng135> |
| Component: | Patrons | Assignee: | Amit Gupta <amitddng135> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | amit.gupta, gmcharlt, kyle.m.hall, martin.renvoize, mtompset |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Branchcode not shown in files.pl
Bug 20719 - Missing branchcode in /cgi-bin/koha/members/files.pl Bug 20719: USE Branches in TT files Bug 20719 - Add missing USE Branches to files.tt Bug 20719: USE Branches in TT files Bug 20719: Add missing USE Branches to files.tt Bug 20719: USE Branches in TT files |
||
|
Description
Amit Gupta
2018-05-07 12:22:59 UTC
Created attachment 75116 [details]
Branchcode not shown in files.pl
Branchcode not shown in files.pl
Created attachment 75117 [details] [review] Bug 20719 - Missing branchcode in /cgi-bin/koha/members/files.pl Test 1. Hit the page /cgi-bin/koha/members/files.pl?borrowernumber=xx xx is a borrowernumber 2. Apply the patch and reload the page. 3. You can see branchcode on the left handside. This is part of a bigger problem. Need to check these out further. koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/deletemem.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/files.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/nl-search.tt This list was generated by looking at the output of: for i in `git grep circ-menu.inc | grep tt: | cut -f1 -d:`; do echo "*****";echo $i;echo;grep Branch $i;echo "*****"; done | less and then selecting those that lacked Branch. The other cases generally had the required "[% USE Branches %]" This is not an enhancement. The branch code/name should display. It's a minor bug. Created attachment 75142 [details] [review] Bug 20719: USE Branches in TT files TEST PLAN --------- In the staff client on a kohadevbox: 1) Enable the HouseboundModule system preference. 2) Enable the EnableBorrowerFiles system preference. 3) Go to a patron detail page. -- note the Home library is shown. 4) Go to Fines tab (left pane) -- Home library is still shown. 5) Click each of the four horizontal tabs (Account, Pay fines, Create manual invoice, Create manual credit) -- Home library not visible for both create tabs and the account tab 6) Click the 'Create manual invoice' tab, and create some kind of entry. 7) On the 'Account' tab, the table has a 'Details' button. Click that. -- Home library not visible. 8) Click the 'Details' tab in the left pane. 9) Click 'More' button and choose 'Delete' -- Home library not visible when asked for delete confirmation. 10) Cancel that, and if you know how to actually set up the Norwegian system preferences you can figure out how to test the nl-search change. After seeing all these not visible, apply this patch. Repeat all the steps, but this time the Home library should be visible. Created attachment 75143 [details] [review] Bug 20719 - Add missing USE Branches to files.tt Test On a kohadevbox: 0. Enable the EnableBorrowerFiles system preference 1. Go to any patron, and click on the 'Files' tab in the left pane. -- the Home library is not displayed. 2. Apply the patch, restart_all, and reload the page. -- the Home library is now displayed. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 75152 [details] [review] Bug 20719: USE Branches in TT files Works fine. Created attachment 75238 [details] [review] Bug 20719: Add missing USE Branches to files.tt Test On a kohadevbox: 0. Enable the EnableBorrowerFiles system preference 1. Go to any patron, and click on the 'Files' tab in the left pane. -- the Home library is not displayed. 2. Apply the patch, restart_all, and reload the page. -- the Home library is now displayed. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 75239 [details] [review] Bug 20719: USE Branches in TT files TEST PLAN --------- In the staff client on a kohadevbox: 1) Enable the HouseboundModule system preference. 2) Enable the EnableBorrowerFiles system preference. 3) Go to a patron detail page. -- note the Home library is shown. 4) Go to Fines tab (left pane) -- Home library is still shown. 5) Click each of the four horizontal tabs (Account, Pay fines, Create manual invoice, Create manual credit) -- Home library not visible for both create tabs and the account tab 6) Click the 'Create manual invoice' tab, and create some kind of entry. 7) On the 'Account' tab, the table has a 'Details' button. Click that. -- Home library not visible. 8) Click the 'Details' tab in the left pane. 9) Click 'More' button and choose 'Delete' -- Home library not visible when asked for delete confirmation. 10) Cancel that, and if you know how to actually set up the Norwegian system preferences you can figure out how to test the nl-search change. After seeing all these not visible, apply this patch. Repeat all the steps, but this time the Home library should be visible. Works OK. Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! |