Summary: | Move template JavaScript to the footer: Call number browser MARC plugin | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 17858 | ||
Attachments: |
Bug 20731: Move template JavaScript to the footer: Call number browser MARC plugin
Bug 20731: Move template JavaScript to the footer: Call number browser MARC plugin Bug 20731: Move template JavaScript to the footer: Call number browser MARC plugin |
Description
Owen Leonard
2018-05-08 18:13:26 UTC
Created attachment 75183 [details] [review] Bug 20731: Move template JavaScript to the footer: Call number browser MARC plugin This patch modifies the call number browser plugin so that JavaScript is in the footer instead of the header. This patch also makes some unrelated changes: The page title has been corrected; DataTables code has been removed as it was unused. To test, apply the patch and configure a MARC framework to use cn_browser.pl as the plugin for tag 952 subfield o. Open an item for editing. The "Full call number" field should have an active "..." link next to it. Clicking this should trigger a popup window with the Call number browser. Confirm that submitting a new search from this window works correctly. Created attachment 75255 [details] [review] Bug 20731: Move template JavaScript to the footer: Call number browser MARC plugin This patch modifies the call number browser plugin so that JavaScript is in the footer instead of the header. This patch also makes some unrelated changes: The page title has been corrected; DataTables code has been removed as it was unused. To test, apply the patch and configure a MARC framework to use cn_browser.pl as the plugin for tag 952 subfield o. Open an item for editing. The "Full call number" field should have an active "..." link next to it. Clicking this should trigger a popup window with the Call number browser. Confirm that submitting a new search from this window works correctly. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Created attachment 75718 [details] [review] Bug 20731: Move template JavaScript to the footer: Call number browser MARC plugin This patch modifies the call number browser plugin so that JavaScript is in the footer instead of the header. This patch also makes some unrelated changes: The page title has been corrected; DataTables code has been removed as it was unused. To test, apply the patch and configure a MARC framework to use cn_browser.pl as the plugin for tag 952 subfield o. Open an item for editing. The "Full call number" field should have an active "..." link next to it. Clicking this should trigger a popup window with the Call number browser. Confirm that submitting a new search from this window works correctly. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Awesome work all! Pushed to master for 18.11 Enhancement, not backporting to 18.05.x series |