Summary: | indexing/searching not active at end of installation | ||
---|---|---|---|
Product: | Koha | Reporter: | Giuseppe Ciaccio <giuseppe.ciaccio> |
Component: | Installation and upgrade (web-based installer) | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P1 - high | CC: | fridolin.somers, giuseppe.ciaccio, gmcharlt, jonathan.druart, mtj, nick, tomascohen |
Version: | Main | ||
Hardware: | PC | ||
OS: | Linux | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 20234 | ||
Bug Blocks: | |||
Attachments: |
output of "ps ax" before and after koha-common service restart; note the initial absence of koha-indexer (libraryname = ferrer)
Bug 20745: koha-zebra doesn't return the correct error codes Bug 20745: koha-zebra doesn't return the correct error codes Bug 20745: koha-zebra doesn't return the correct error codes |
Description
Giuseppe Ciaccio
2018-05-09 13:52:25 UTC
Important remark: I've read somewhere that the Koha indexing may incur delays, or happens periodically, and therefore a recently inserted record does not appear immediately in the search but will do after some minutes. This is not the case here: after restarting the koha-common services, I see that each new record appears immediately in the search results ("immediately" means "less than 5 seconds after insert"). Hum, I do not know what your missing here but it should just work. It's not related to the installation process, the koha-create command should start a koha-indexer process to take care of the indexation. Maybe it did not start correctly? As a further detail: in my attempts I always start from a fresh Debian 9.4 default install, to be sure nothing has remained from past attempts (this means: all partitions are formatted and then the OS is installed, and finally I install Koha following very strictly the instructions at https://wiki.koha-community.org/wiki/Debian). As of now I have tried with marc21 flavour and english, and marc21 and it-IT, with same results. This evening I will try with unimarc flavour. I've done a test with unimarc flavour and english or it-IT as the installation language, nothing changes. The inserted records become searchable only after "service koha-common stop && service koha-common start". However, after completing the install/config wizard, I looked at the output of "ps ax" before and after service restart, and noted that, after restart, a new daemon process appeared, called <libraryname>-koha-indexer, which was missing before. I will send a logfile to show this. IMHO the wizard, or the initial koha-create command, fails launching the koha-indexer, and that's why the indexing/searching provides no results until the service is manually restarted. Created attachment 75217 [details]
output of "ps ax" before and after koha-common service restart; note the initial absence of koha-indexer (libraryname = ferrer)
% sudo koha-create --create-db xxx Koha instance is empty, no staff user created. % ps aux | grep xxx-koha-zebra xxx-koha 3534 0.1 0.0 18608 188 ? S 10:09 0:00 daemon --name=xxx-koha-zebra --pidfiles=/var/run/koha/xxx/ --errlog=/var/log/koha/xxx/zebra-error.log --output=/var/log/koha/xxx/zebra-output.log --verbose=1 --respawn --delay=30 --user=xxx-koha.xxx-koha -- /usr/bin/zebrasrv -v none,fatal,warn -f /etc/koha/sites/xxx/koha-conf.xml Looks ok for me. (In reply to Jonathan Druart from comment #6) > % sudo koha-create --create-db xxx > Koha instance is empty, no staff user created. > % ps aux | grep xxx-koha-zebra > xxx-koha 3534 0.1 0.0 18608 188 ? S 10:09 0:00 daemon > --name=xxx-koha-zebra --pidfiles=/var/run/koha/xxx/ > --errlog=/var/log/koha/xxx/zebra-error.log > --output=/var/log/koha/xxx/zebra-output.log --verbose=1 --respawn --delay=30 > --user=xxx-koha.xxx-koha -- /usr/bin/zebrasrv -v none,fatal,warn -f > /etc/koha/sites/xxx/koha-conf.xml > > Looks ok for me. what about the indexer? heh, it's missing :) (In reply to Jonathan Druart from comment #8) > heh, it's missing :) --- a/misc/migration_tools/rebuild_zebra.pl +++ b/misc/migration_tools/rebuild_zebra.pl @@ -242,9 +242,14 @@ if ($daemon_mode) { if (_flock($LockFH, LOCK_EX|LOCK_NB)) { eval { $dbh = C4::Context->dbh; - if( zebraqueue_not_empty() ) { - Koha::Caches->flush_L1_caches() if $is_memcached; - do_one_pass(); + if ( C4::Context->preference('Version') ) { + if( zebraqueue_not_empty() ) { + Koha::Caches->flush_L1_caches() if $is_memcached; + do_one_pass(); + } + } + else { + warn "Warning: Koha is not installed."; } To my understanding the problem is in koha-zebra. koha-create calls: koha-zebra --start "$name" And then exit 1 it's because the function start_zebra (from koha-zebra) returns an error with: [ "$verbose" != "no" ] && \ log_end_msg 0 Certainly caused by bug 20234. Created attachment 75227 [details] [review] Bug 20745: koha-zebra doesn't return the correct error codes This patch makes koha-zebra return 0 (or 1) even when verbose mode is off. This made koha-zebra --start always return a failure even when the daemon was correctly launched. To test: - Have Zebra running for kohadev instance on your KohaDevBox - Run: $ sudo koha-zebra --stop kohadev && echo yay || echo doh => FAIL: 'doh' is printed - Run: $ sudo koha-zebra --start kohadev e&& echo yay || echo doh => FAIL: 'doh' is printed as well - Apply this patch - Run: $ sudo perl misc4dev/cp_debian_files.pl $ sudo koha-zebra --stop kohadev && echo yay || echo doh => SUCCESS: 'yay' is printed - Run: $ sudo koha-zebra --start kohadev e&& echo yay || echo doh => SUCCESS: 'yay' is printed - Sign off :-D Sponsored-by: ByWater Solutions Added the 17.11 RMaint because the original patches got backported. Created attachment 75231 [details] [review] Bug 20745: koha-zebra doesn't return the correct error codes This patch makes koha-zebra return 0 (or 1) even when verbose mode is off. This made koha-zebra --start always return a failure even when the daemon was correctly launched. To test: - Have Zebra running for kohadev instance on your KohaDevBox - Run: $ sudo koha-zebra --stop kohadev && echo yay || echo doh => FAIL: 'doh' is printed - Run: $ sudo koha-zebra --start kohadev e&& echo yay || echo doh => FAIL: 'doh' is printed as well - Apply this patch - Run: $ sudo perl misc4dev/cp_debian_files.pl $ sudo koha-zebra --stop kohadev && echo yay || echo doh => SUCCESS: 'yay' is printed - Run: $ sudo koha-zebra --start kohadev e&& echo yay || echo doh => SUCCESS: 'yay' is printed - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 75233 [details] [review] Bug 20745: koha-zebra doesn't return the correct error codes This patch makes koha-zebra return 0 (or 1) even when verbose mode is off. This made koha-zebra --start always return a failure even when the daemon was correctly launched. To test: - Have Zebra running for kohadev instance on your KohaDevBox - Run: $ sudo koha-zebra --stop kohadev && echo yay || echo doh => FAIL: 'doh' is printed - Run: $ sudo koha-zebra --start kohadev e&& echo yay || echo doh => FAIL: 'doh' is printed as well - Apply this patch - Run: $ sudo perl misc4dev/cp_debian_files.pl $ sudo koha-zebra --stop kohadev && echo yay || echo doh => SUCCESS: 'yay' is printed - Run: $ sudo koha-zebra --start kohadev e&& echo yay || echo doh => SUCCESS: 'yay' is printed - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! (In reply to Tomás Cohen Arazi from comment #13) > Added the 17.11 RMaint because the original patches got backported. Frido, just confirming this bug exists in 17.11.07 the patch fixes the bug :) (In reply to Mason James from comment #17) > (In reply to Tomás Cohen Arazi from comment #13) > > Added the 17.11 RMaint because the original patches got backported. > > Frido, just confirming this bug exists in 17.11.07 > > the patch fixes the bug :) Ohhh thanks for this, I will backport Pushed to 17.11.x for 17.11.08 Depends on Bug 20234 not in 17.05.x |