Summary: | Improve behaviour of onboarding tool for Italian by standardizing file structure of it-IT installer | ||
---|---|---|---|
Product: | Koha | Reporter: | Giuseppe Ciaccio <giuseppe.ciaccio> |
Component: | Installation and upgrade (web-based installer) | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P3 | CC: | giuseppe.ciaccio, gmcharlt, jonathan.druart, martin.renvoize, mtompset |
Version: | Main | ||
Hardware: | PC | ||
OS: | Linux | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 20746: Move it-IT files to optional
k Bug 20746: Move it-IT files to optional Bug 20746: Move it-IT files to optional |
Description
Giuseppe Ciaccio
2018-05-09 16:04:40 UTC
This step is skipped because patron categories are marked as "mandatory", they are in the following files: installer/data/mysql/it-IT/necessari/patron_categories.sql If you uncheck the checkbox related to this file, you will see this step. Fine, but then I cannot see the reason why a "mandatory" step could be optional. Anyway the real point is that I would not expect the default behaviour of an install wizard to depend on the chosen language. IMHO this must be fixed (and the fix seems trivial, by the way). The main problem I guess is that italian installer files do not follow the same pattern as other installer files. Created attachment 75212 [details] [review] Bug 20746: Move it-IT files to optional Created attachment 75228 [details] [review] k Created attachment 75229 [details] [review] Bug 20746: Move it-IT files to optional Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 75236 [details] [review] Bug 20746: Move it-IT files to optional Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Counting Mark for SO and mine for QA. Pushed to master for 18.05, thanks to everybody involved! |