Bug 20777

Summary: Remove unused field accountlines.dispute
Product: Koha Reporter: Tomás Cohen Arazi <tomascohen>
Component: DatabaseAssignee: Tomás Cohen Arazi <tomascohen>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: fridolin.somers, martin.renvoize, mtj, mtompset, nick
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 20396    
Attachments: Bug 20777: Remove unused accountlines.dispute field
Bug 20777: DBIC update
Bug 20777: (follow-up) Remove 'dispute' reference in /credits endpoint
Bug 20777: Remove unused accountlines.dispute field
Bug 20777: DBIC update
Bug 20777: (follow-up) Remove 'dispute' reference in /credits endpoint
Bug 20777: Remove unused accountlines.dispute field
Bug 20777: DBIC update
Bug 20777: (follow-up) Remove 'dispute' reference in /credits endpoint

Description Tomás Cohen Arazi 2018-05-17 13:47:27 UTC
This field is not used on the code base.
Comment 1 Tomás Cohen Arazi 2018-05-17 13:55:52 UTC
Created attachment 75397 [details] [review]
Bug 20777: Remove unused accountlines.dispute field

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 Tomás Cohen Arazi 2018-05-17 13:55:59 UTC
Created attachment 75398 [details] [review]
Bug 20777: DBIC update

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Mark Tompsett 2018-09-14 14:39:08 UTC
git grep -i dispute finds a REST API reference to dispute. Shouldn't that be removed too?
Comment 4 Tomás Cohen Arazi 2018-09-14 16:11:19 UTC
Created attachment 78665 [details] [review]
Bug 20777: (follow-up) Remove 'dispute' reference in /credits endpoint

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 5 Mark Tompsett 2018-09-14 17:34:14 UTC
Created attachment 78671 [details] [review]
Bug 20777: Remove unused accountlines.dispute field

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 6 Mark Tompsett 2018-09-14 17:34:17 UTC
Created attachment 78672 [details] [review]
Bug 20777: DBIC update

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 7 Mark Tompsett 2018-09-14 17:34:21 UTC
Created attachment 78673 [details] [review]
Bug 20777: (follow-up) Remove 'dispute' reference in /credits endpoint

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 8 Jonathan Druart 2018-09-15 20:55:34 UTC
Created attachment 78893 [details] [review]
Bug 20777: Remove unused accountlines.dispute field

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 9 Jonathan Druart 2018-09-15 20:55:37 UTC
Created attachment 78894 [details] [review]
Bug 20777: DBIC update

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 10 Jonathan Druart 2018-09-15 20:55:41 UTC
Created attachment 78895 [details] [review]
Bug 20777: (follow-up) Remove 'dispute' reference in /credits endpoint

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 11 Nick Clemens 2018-09-15 23:29:02 UTC
Awesome work all!

Pushed to master for 18.11
Comment 12 Martin Renvoize 2018-09-17 14:29:44 UTC
Pushed to 18.05.x for 18.05.04.

Go code cleanup :)
Comment 13 Fridolin Somers 2018-09-24 10:08:20 UTC
I prefer not push to 17.11.x to have this change in a major upgrade