Summary: | Remove unused field accountlines.dispute | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi <tomascohen> |
Component: | Database | Assignee: | Tomás Cohen Arazi <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, martin.renvoize, mtj, mtompset, nick |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 20396 | ||
Attachments: |
Bug 20777: Remove unused accountlines.dispute field
Bug 20777: DBIC update Bug 20777: (follow-up) Remove 'dispute' reference in /credits endpoint Bug 20777: Remove unused accountlines.dispute field Bug 20777: DBIC update Bug 20777: (follow-up) Remove 'dispute' reference in /credits endpoint Bug 20777: Remove unused accountlines.dispute field Bug 20777: DBIC update Bug 20777: (follow-up) Remove 'dispute' reference in /credits endpoint |
Description
Tomás Cohen Arazi
2018-05-17 13:47:27 UTC
Created attachment 75397 [details] [review] Bug 20777: Remove unused accountlines.dispute field Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 75398 [details] [review] Bug 20777: DBIC update Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> git grep -i dispute finds a REST API reference to dispute. Shouldn't that be removed too? Created attachment 78665 [details] [review] Bug 20777: (follow-up) Remove 'dispute' reference in /credits endpoint Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 78671 [details] [review] Bug 20777: Remove unused accountlines.dispute field Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 78672 [details] [review] Bug 20777: DBIC update Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 78673 [details] [review] Bug 20777: (follow-up) Remove 'dispute' reference in /credits endpoint Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 78893 [details] [review] Bug 20777: Remove unused accountlines.dispute field Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 78894 [details] [review] Bug 20777: DBIC update Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 78895 [details] [review] Bug 20777: (follow-up) Remove 'dispute' reference in /credits endpoint Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.04. Go code cleanup :) I prefer not push to 17.11.x to have this change in a major upgrade |