Summary: | Don't show holds tab when user doesn't have circulate_remaining_permissions | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Circulation | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | amitddng135, fridolin.somers, gmcharlt, jonathan.druart, kyle.m.hall, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 20794: Hide holds tab on details when user lacks circulate_remaining_permissions
Bug 20794: Hide holds tab on details when user lacks circulate_remaining_permissions Bug 20794: Hide holds tab on details when user lacks circulate_remaining_permissions |
Description
Katrin Fischer
2018-05-20 02:23:17 UTC
Created attachment 75447 [details] [review] Bug 20794: Hide holds tab on details when user lacks circulate_remaining_permissions If a user doesn't have circulate_remaining permissions, but has borrowers: - checkouts tab is hidden - details tab is visible - holds tab on details is visible, but results in an error The problem is that the svc/holds script requires circulate_remaining_permissions. To test: - Create 2 staff users with and without circulate_remaining_permissions Both need borrowers permission - Go to the details tab in a patron's account who has holds - Verify that you get a datatables error for the staff patron without circulate_remaining_permissions - Apply patch - Verify that now the holds tab is no longer displayed for this patron Created attachment 75944 [details] [review] Bug 20794: Hide holds tab on details when user lacks circulate_remaining_permissions Work OK --------------- Test If a user doesn't have circulate_remaining permissions, but has borrowers: - checkouts tab is hidden - details tab is visible - holds tab on details is visible, but results in an error The problem is that the svc/holds script requires circulate_remaining_permissions. To test: - Create 2 staff users with and without circulate_remaining_permissions Both need borrowers permission - Go to the details tab in a patron's account who has holds - Verify that you get a datatables error for the staff patron without circulate_remaining_permissions - Apply patch - Verify that now the holds tab is no longer displayed for this patron I have no idea if the permissions are ok but this patch makes sense as a quick fix at least. Created attachment 76174 [details] [review] Bug 20794: Hide holds tab on details when user lacks circulate_remaining_permissions If a user doesn't have circulate_remaining permissions, but has borrowers: - checkouts tab is hidden - details tab is visible - holds tab on details is visible, but results in an error The problem is that the svc/holds script requires circulate_remaining_permissions. To test: - Create 2 staff users with and without circulate_remaining_permissions Both need borrowers permission - Go to the details tab in a patron's account who has holds - Verify that you get a datatables error for the staff patron without circulate_remaining_permissions - Apply patch - Verify that now the holds tab is no longer displayed for this patron Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Awesome work all! Pushed to master for 18.11.x Pushed to 18.05.x for 18.05.02 Pushed to 17.11.x for 17.11.08 |