|
Description
Magnus Enger
2018-05-22 07:45:25 UTC
*** Bug 18592 has been marked as a duplicate of this bug. *** Created attachment 96102 [details]
Screenshot - proposed display for links to ILL request(s)
Normaly there will only be one ILL request connected to a bibliographic record. The screenshot shows the proposed way of displaying one or more links to connected ILL requests: as linked ILL request IDs.
Created attachment 96103 [details]
Suggested interface alternative
I think it would be confusing to use the same styling for these links as for the holds count. We use that style for a link which expresses a count of things and links to a list of those things.
My suggestion is to use plain links, separated by a comma if there are multiple, and to label the links so that it is more clear what the number means.
Created attachment 96105 [details] [review] Bug 20799 - Add link from biblio to ILL detail view Some ILL systems (e.g. Libris in Sweden) require a link between a biblio and an ILL request. When such a link exists it is nice to display an actual link from the biblio detail view to the ILL request detail view. This patch adds such a link. For users without ILL privileges, the requests should still show, but not be clickable links. To test: - Make sure you have a couple of ILL requests created with the FreeForm backend. (FreeForm does not let you tie a request to a biblio through the UI, but we will add connections directly in the database.) Lets assume these have illrequest_id's a and b. - Make sure you have a record, let's call the biblionumber x. - Apply the patch and make sure there are no changes in the biblio detail view of biblionumber x. - Log into the database and connect the biblio to the first request: UPDATE illrequests SET biblio_id = x where illrequest_id = a; - Check that the biblio detail view now says this: "ILL requests: Request a" - Verify that the "Request a" part is a working link to the detail view of ILL request a. - Do this in the database: UPDATE illrequests SET biblio_id = x where illrequest_id = b; - Check that the biblio detail view now says this: "ILL requests: Request a, Request b" - Verify the links work as expected. - Log in as a staff user and check that the requests are still listed, but not displayed as clickable links. - Sign off This patch uses the recommendations from Owen. Created attachment 106407 [details] [review] Bug 20799: Add link from biblio to ILL detail view Some ILL systems (e.g. Libris in Sweden) require a link between a biblio and an ILL request. When such a link exists it is nice to display an actual link from the biblio detail view to the ILL request detail view. This patch adds such a link. For users without ILL privileges, the requests should still show, but not be clickable links. To test: - Make sure you have a couple of ILL requests created with the FreeForm backend. (FreeForm does not let you tie a request to a biblio through the UI, but we will add connections directly in the database.) Lets assume these have illrequest_id's a and b. - Make sure you have a record, let's call the biblionumber x. - Apply the patch and make sure there are no changes in the biblio detail view of biblionumber x. - Log into the database and connect the biblio to the first request: UPDATE illrequests SET biblio_id = x where illrequest_id = a; - Check that the biblio detail view now says this: "ILL requests: Request a" - Verify that the "Request a" part is a working link to the detail view of ILL request a. - Do this in the database: UPDATE illrequests SET biblio_id = x where illrequest_id = b; - Check that the biblio detail view now says this: "ILL requests: Request a, Request b" - Verify the links work as expected. - Log in as a staff user and check that the requests are still listed, but not displayed as clickable links. - Sign off Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 106408 [details] [review] Bug 20799: (follow-up) Add ILLModule system preference check and fix display for no requests When there were no requests the label would still display, using .count fixes this. Also adds a check on the ILLModule system preference to prevent the information from showing when the ILL module is deactivated. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> I could see this moved into a tab in the future, but it's a really nice little enhancement as is that will ease the workflow a lot. Created attachment 106584 [details] [review] Bug 20799: Add link from biblio to ILL detail view Some ILL systems (e.g. Libris in Sweden) require a link between a biblio and an ILL request. When such a link exists it is nice to display an actual link from the biblio detail view to the ILL request detail view. This patch adds such a link. For users without ILL privileges, the requests should still show, but not be clickable links. To test: - Make sure you have a couple of ILL requests created with the FreeForm backend. (FreeForm does not let you tie a request to a biblio through the UI, but we will add connections directly in the database.) Lets assume these have illrequest_id's a and b. - Make sure you have a record, let's call the biblionumber x. - Apply the patch and make sure there are no changes in the biblio detail view of biblionumber x. - Log into the database and connect the biblio to the first request: UPDATE illrequests SET biblio_id = x where illrequest_id = a; - Check that the biblio detail view now says this: "ILL requests: Request a" - Verify that the "Request a" part is a working link to the detail view of ILL request a. - Do this in the database: UPDATE illrequests SET biblio_id = x where illrequest_id = b; - Check that the biblio detail view now says this: "ILL requests: Request a, Request b" - Verify the links work as expected. - Log in as a staff user and check that the requests are still listed, but not displayed as clickable links. - Sign off Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 106585 [details] [review] Bug 20799: (follow-up) Add ILLModule system preference check and fix display for no requests When there were no requests the label would still display, using .count fixes this. Also adds a check on the ILLModule system preference to prevent the information from showing when the ILL module is deactivated. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Works well, passes QA scripts and no regressions found. Passing QA Instead of having the syspref check in the template I think it would make more sense to have it in the controller script (to avoid necessary request if ILL is not enabled). Created attachment 107175 [details] [review] Bug 20799: (QA follow-up) Move syspref check This patch moves the syspref check into the controller to save a DB query if the module is not enabled. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Good catch.. I've moved the syspref check into the controller, using it in a ternary to govern whether we return an empty array or execute the search. Created attachment 107277 [details] [review] Bug 20799: (QA follow-up) Move syspref check This patch moves the syspref check into the controller to save a DB query if the module is not enabled. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> JD - amended patch: removing trailing parenthesis in the IF statement Pushed to master for 20.11, thanks to everybody involved! not backporting enhancement to 20.05.x series |