| Summary: | UNIMARC XSLT does not display 604$t | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
| Component: | Searching | Assignee: | Fridolin Somers <fridolin.somers> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | lucas, martin.renvoize, nick, sandboxes, severine.queune |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 20823: UNIMARC XSLT add subfield t for subjects
Bug 20823: UNIMARC XSLT add subfield t for subjects Bug 20823: UNIMARC XSLT add subfield t for subjects |
||
|
Description
Fridolin Somers
2018-05-25 14:50:42 UTC
Created attachment 75566 [details] [review] Bug 20823: UNIMARC XSLT add subfield t for subjects In UNIMARC, 604 contains subfield t, see http://multimedia.bnf.fr/unimarcb_trad/B604-6-2011.pdf. Actual XSLT files use template tag_subject for 604, it does not use t subfield. This patch adds subfield t to tag_subject and tag_onesubject templates in intranet and OPAC XSLT files. Test plan : 1) In UNIMARC catalog edit a biblio record to add 604$t 2) Use default XSLT files in sysprefs 2) Go to catalogue details page of this record using default XSLT files 3) Check $t is displayed at OPAC and intranet Works correctly for Intranet but on OPAC, only the label is displayed. I reproduce when 604 contains only $t. But I've seen UNIMARC 604 has $a mandatory. Please check with 604 $a and $t. Sorry Frido for the delay, I completely missed your comment ! (In reply to Fridolin SOMERS from comment #3) > I reproduce when 604 contains only $t. > But I've seen UNIMARC 604 has $a mandatory. > Please check with 604 $a and $t. You're right, 604$t is correctly displayed when there is a 604$a, but the display depends of the order of creation of the fields ($t will be displayed first if created first, and vice verse for $a), is that normal ? When I have several 604 subfields, the link is the same for all the 604 values, but the new search is only done on the first displayed value : shouldn’t we have a link for each subfield ? (In reply to Séverine Queune from comment #4) > Sorry Frido for the delay, I completely missed your comment ! > > (In reply to Fridolin SOMERS from comment #3) > > I reproduce when 604 contains only $t. > > But I've seen UNIMARC 604 has $a mandatory. > > Please check with 604 $a and $t. > You're right, 604$t is correctly displayed when there is a 604$a, but the > display depends of the order of creation of the fields ($t will be displayed > first if created first, and vice verse for $a), is that normal ? I'd say yes. > > When I have several 604 subfields, the link is the same for all the 604 > values, but the new search is only done on the first displayed value : > shouldn’t we have a link for each subfield ? Oh, this patch only adds $t to the tag_subject template call. This is the behavior of tag_subject template, you may open a new bug. (In reply to Fridolin SOMERS from comment #5) > (In reply to Séverine Queune from comment #4) > > Sorry Frido for the delay, I completely missed your comment ! > > > > (In reply to Fridolin SOMERS from comment #3) > > > I reproduce when 604 contains only $t. > > > But I've seen UNIMARC 604 has $a mandatory. > > > Please check with 604 $a and $t. > > You're right, 604$t is correctly displayed when there is a 604$a, but the > > display depends of the order of creation of the fields ($t will be displayed > > first if created first, and vice verse for $a), is that normal ? > > I'd say yes. > Great ! Let's sign it then :) > > > > When I have several 604 subfields, the link is the same for all the 604 > > values, but the new search is only done on the first displayed value : > > shouldn’t we have a link for each subfield ? > > Oh, this patch only adds $t to the tag_subject template call. > This is the behavior of tag_subject template, you may open a new bug. Ok, I'll do it. Thanks Frido ! Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr> Created attachment 85771 [details] [review] Bug 20823: UNIMARC XSLT add subfield t for subjects In UNIMARC, 604 contains subfield t, see http://multimedia.bnf.fr/unimarcb_trad/B604-6-2011.pdf. Actual XSLT files use template tag_subject for 604, it does not use t subfield. This patch adds subfield t to tag_subject and tag_onesubject templates in intranet and OPAC XSLT files. Test plan : 1) In UNIMARC catalog edit a biblio record to add 604$t 2) Use default XSLT files in sysprefs 2) Go to catalogue details page of this record using default XSLT files 3) Check $t is displayed at OPAC and intranet Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Created attachment 86533 [details] [review] Bug 20823: UNIMARC XSLT add subfield t for subjects In UNIMARC, 604 contains subfield t, see http://multimedia.bnf.fr/unimarcb_trad/B604-6-2011.pdf. Actual XSLT files use template tag_subject for 604, it does not use t subfield. This patch adds subfield t to tag_subject and tag_onesubject templates in intranet and OPAC XSLT files. Test plan : 1) In UNIMARC catalog edit a biblio record to add 604$t 2) Use default XSLT files in sysprefs 2) Go to catalogue details page of this record using default XSLT files 3) Check $t is displayed at OPAC and intranet Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Trivial patch that does what it says on the tin.. Passing QA Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.04 backported to 18.05.x for 18.05.12 |