| Summary: | OpacAddMastheadLibraryPulldown displays an empty list | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | fridolin.somers, martin.renvoize, nick |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 16735, 20838 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 20875: (bug 16735 follow-up) Fix library list for OpacAddMastheadLibraryPulldown
Bug 20875: (bug 16735 follow-up) Fix library list for OpacAddMastheadLibraryPulldown Bug 20875: (bug 16735 follow-up) Fix library list for OpacAddMastheadLibraryPulldown |
||
|
Description
Jonathan Druart
2018-06-04 14:12:27 UTC
Created attachment 75773 [details] [review] Bug 20875: (bug 16735 follow-up) Fix library list for OpacAddMastheadLibraryPulldown This patch fixes a regression introduced by commit 2059f7d8016ab61172830e9b670279d3e28882b7 Bug 16735: Migrate library search groups into the new hierarchical groups It re-added code that was removed by bug 15758 (use of var BranchesLoop). Test plan: - Create library search groups - Turn OpacAddMastheadLibraryPulldown on - At the OPAC confirm that the search box with libraries and library groups is displayed and works correctly. - Remove the library search group - The dropdown list should not have the optgroup tags Created attachment 75790 [details] [review] Bug 20875: (bug 16735 follow-up) Fix library list for OpacAddMastheadLibraryPulldown This patch fixes a regression introduced by commit 2059f7d8016ab61172830e9b670279d3e28882b7 Bug 16735: Migrate library search groups into the new hierarchical groups It re-added code that was removed by bug 15758 (use of var BranchesLoop). Test plan: - Create library search groups - Turn OpacAddMastheadLibraryPulldown on - At the OPAC confirm that the search box with libraries and library groups is displayed and works correctly. - Remove the library search group - The dropdown list should not have the optgroup tags Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Thx Martin for catching the forgotten status change! Created attachment 75867 [details] [review] Bug 20875: (bug 16735 follow-up) Fix library list for OpacAddMastheadLibraryPulldown This patch fixes a regression introduced by commit 2059f7d8016ab61172830e9b670279d3e28882b7 Bug 16735: Migrate library search groups into the new hierarchical groups It re-added code that was removed by bug 15758 (use of var BranchesLoop). Test plan: - Create library search groups - Turn OpacAddMastheadLibraryPulldown on - At the OPAC confirm that the search box with libraries and library groups is displayed and works correctly. - Remove the library search group - The dropdown list should not have the optgroup tags Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Simple change works as expected and doesn't break any tests. I'd love to see an accompanying selenium (or whatever) integration test, but as we don't yet have a clear framework for such tests I can't justifiably fail it for not having one. Pushed to master for 18.11, awesome work all! This patch has been pushed to 18.05.x and will be in 18.05.01 |