| Summary: | Order receiving: Price filter missing on_editing | ||
|---|---|---|---|
| Product: | Koha | Reporter: | paxed <pasi.kallinen> | 
| Component: | Templates | Assignee: | paxed <pasi.kallinen> | 
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> | 
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, martin.renvoize, nick | 
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20976 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Bug Depends on: | 13352 | ||
| Bug Blocks: | |||
| Attachments: | Bug 20881: Order receiving: Price filter missing on_editing Bug 20881: Order receiving: Price filter missing on_editing Bug 20881: Order receiving: Price filter missing on_editing | ||
| 
        
          Description
        
        
          paxed
        
        
        
        
          2018-06-05 10:43:30 UTC
        
       Created attachment 75809 [details] [review] Bug 20881: Order receiving: Price filter missing on_editing This is quite a problem working with comma-separated decimals, upping severity a bit. Created attachment 76195 [details] [review] Bug 20881: Order receiving: Price filter missing on_editing When the Price-filter is used on editable data, it should have the on_editing -tag. Add it to the orderreceive.tt Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> To test: - Set CurrencyFormat to FR - Create a basket with orders in acq - Close it - Receive shipment and pick order line to receive - On this screen verify that the actual cost appears as comma-separated - Apply patch - Refresh page - Verify that the actual cost now appears .-separated Created attachment 76236 [details] [review] Bug 20881: Order receiving: Price filter missing on_editing When the Price-filter is used on editable data, it should have the on_editing -tag. Add it to the orderreceive.tt Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> To test: - Set CurrencyFormat to FR - Create a basket with orders in acq - Close it - Receive shipment and pick order line to receive - On this screen verify that the actual cost appears as comma-separated - Apply patch - Refresh page - Verify that the actual cost now appears .-separated Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Awesome work all! Pushed to master for 18.11.x Pushed to 18.05.x for 18.05.02 Pushed to 17.11.x for 17.11.08 |