Bug 20885

Summary: Transferring an item on hold results in bypassing restrictions, actually doing the transfer and can be piled up if repeated
Product: Koha Reporter: Victor Grousset/tuxayo <victor>
Component: CirculationAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P4 CC: gmcharlt, kyle.m.hall, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20344
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Victor Grousset/tuxayo 2018-06-06 09:14:40 UTC
The first name was «Transferring an item on hold results in chaos»

Disclaimer: I'm not sure if what I did makes sense from a functional point of view.

== Test plan ==
1. Add transfer restrictions
     staff:/cgi-bin/koha/admin/branch_transfer_limits.pl
     For all item types => clear all
2. Place a hold on a record
3. go to the transfer page staff:/cgi-bin/koha/circ/branchtransfers.pl
4. Try to transfer the item
5. You should see the message «Transfer is not allowed for [...]»
   OR retry with another site to fall into your restrictions
6. But you also see the "Transferred items" table showing the transfer
     This is a bug. The transfer shouldn't have been scheduled.
7. On the same page: redo a transfer
8. You should see "Item is already at destination library."
     This is a bug. This is even worst. The transfer shouldn't have
     been actually done!
9. But wait there is more, the transfer has been add to the table.
     This is a bug. It's still scheduled anyway.
     A transfer to the same branch!
10. Redo it again and it will pile up!
11. Raise your hands and ask loudly: Why!


Tried on master the 24 of April and on version 16.11.15
To ensure that bug 19530 hadn't an influence on this.

Might be related to bug 20344
Comment 1 Victor Grousset/tuxayo 2018-06-07 14:39:16 UTC
A librarian confirmed that the test plan isn't bugus.
Comment 2 Martin Renvoize 2020-10-02 12:39:47 UTC
Is this still happening?
Comment 3 Victor Grousset/tuxayo 2020-11-14 12:41:35 UTC
> 5. You should see the message «Transfer is not allowed for [...]»
>   OR retry with another site to fall into your restrictions

I can't make a transfer fail due restrictions.
One should go staff:/cgi-bin/koha/admin/branch_transfer_limits.pl
untick all, save and then any transfer should fail right?

I'm still able to do a transfer to the origin branch. (A to A) And to pile them up.