Summary: | 773$g not displayed if $0 is present | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi <tomascohen> |
Component: | MARC Bibliographic data support | Assignee: | Tomás Cohen Arazi <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, julian.maurice, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11849 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5528 |
||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 20910: Display 773$g when $0 is present too
Bug 20910: Tidy 773 handling XSLT code Bug 20910: Display 773$g when $0 is present too Bug 20910: Tidy 773 handling XSLT code Bug 20910: Display 773$g when $0 is present too Bug 20910: Tidy 773 handling XSLT code |
Description
Tomás Cohen Arazi
2018-06-11 14:30:17 UTC
Created attachment 75960 [details] [review] Bug 20910: Display 773$g when $0 is present too This patch makes the XSLT logic add the $g subfield in the 773 display in both the OPAC and staff interface MARC21 record detail pages. The XSLT chooses between different ways to create the link for the related content, but then it only adds the $g in two of the cases. There's no obvious reason for a different display. To test: - Have a record with: =773 $tHost title $gp4. => SUCCESS: Notice the Detail view shows: In: Host title p4. - Have another record with: =773 $tHost title $gp4. $w100 - Enable UseControlNumber (only to cover the case): => SUCCESS: Notice the detail view shows In: Host title p4. - Have another record with: =773 $tHost title $gp4. $0456 => FAIL: The Detail view doesn't show p4. - Apply this patch - Reload => SUCCESS: The Detail view displays p4.! - Sign off :-D Sponsored-by: Escuela de Orientacion Lacaniana Created attachment 75961 [details] [review] Bug 20910: Tidy 773 handling XSLT code There's happiness too. You know. Sponsored-by: Escuela de Orientacion Lacaniana Created attachment 78741 [details] [review] Bug 20910: Display 773$g when $0 is present too This patch makes the XSLT logic add the $g subfield in the 773 display in both the OPAC and staff interface MARC21 record detail pages. The XSLT chooses between different ways to create the link for the related content, but then it only adds the $g in two of the cases. There's no obvious reason for a different display. To test: - Have a record with: =773 $tHost title $gp4. => SUCCESS: Notice the Detail view shows: In: Host title p4. - Have another record with: =773 $tHost title $gp4. $w100 - Enable UseControlNumber (only to cover the case): => SUCCESS: Notice the detail view shows In: Host title p4. - Have another record with: =773 $tHost title $gp4. $0456 => FAIL: The Detail view doesn't show p4. - Apply this patch - Reload => SUCCESS: The Detail view displays p4.! - Sign off :-D Sponsored-by: Escuela de Orientacion Lacaniana Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Created attachment 78742 [details] [review] Bug 20910: Tidy 773 handling XSLT code There's happiness too. You know. Sponsored-by: Escuela de Orientacion Lacaniana Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Created attachment 80123 [details] [review] Bug 20910: Display 773$g when $0 is present too This patch makes the XSLT logic add the $g subfield in the 773 display in both the OPAC and staff interface MARC21 record detail pages. The XSLT chooses between different ways to create the link for the related content, but then it only adds the $g in two of the cases. There's no obvious reason for a different display. To test: - Have a record with: =773 $tHost title $gp4. => SUCCESS: Notice the Detail view shows: In: Host title p4. - Have another record with: =773 $tHost title $gp4. $w100 - Enable UseControlNumber (only to cover the case): => SUCCESS: Notice the detail view shows In: Host title p4. - Have another record with: =773 $tHost title $gp4. $0456 => FAIL: The Detail view doesn't show p4. - Apply this patch - Reload => SUCCESS: The Detail view displays p4.! - Sign off :-D Sponsored-by: Escuela de Orientacion Lacaniana Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Created attachment 80124 [details] [review] Bug 20910: Tidy 773 handling XSLT code There's happiness too. You know. Sponsored-by: Escuela de Orientacion Lacaniana Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x fro 18.05.05. I chose to only backport the first patch.. should aid in easy identification of the change vs the tidy for server admins. 1st patch : Pushed to 17.11.x for 17.11.12 |