Summary: | left-side navigation broken on the checkout history page | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, josef.moravec, martin.renvoize, nick |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 18403 | ||
Bug Blocks: | |||
Attachments: |
Bug 20918: Fix left-side navigation on the checkout history page
Bug 20918: Fix left-side navigation on the checkout history page Bug 20918: Fix left-side navigation on the checkout history page |
Description
Jonathan Druart
2018-06-12 14:25:13 UTC
Created attachment 75994 [details] [review] Bug 20918: Fix left-side navigation on the checkout history page commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] Removed: - biblionumber => $biblionumber, # required for left-side navigation But did not deal with the side-effects. Test plan: When you are on the "Checkout history" page (/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=42), the left-side navigation is broken if this patch is not applied, the biblionumber is not set. Created attachment 75999 [details] [review] Bug 20918: Fix left-side navigation on the checkout history page commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] Removed: - biblionumber => $biblionumber, # required for left-side navigation But did not deal with the side-effects. Test plan: When you are on the "Checkout history" page (/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=42), the left-side navigation is broken if this patch is not applied, the biblionumber is not set. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Good spot, signing off. Created attachment 76038 [details] [review] Bug 20918: Fix left-side navigation on the checkout history page commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] Removed: - biblionumber => $biblionumber, # required for left-side navigation But did not deal with the side-effects. Test plan: When you are on the "Checkout history" page (/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=42), the left-side navigation is broken if this patch is not applied, the biblionumber is not set. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.01 |