Summary: | Plack timeout because of missing CGI::Compile Perl dependency | ||
---|---|---|---|
Product: | Koha | Reporter: | Jerome Charaoui <jcharaoui> |
Component: | Packaging | Assignee: | Jerome Charaoui <jcharaoui> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, martin.renvoize, mirko, nick |
Version: | Main | Keywords: | dependency |
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20693 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Patch for debian/control
bug 20920: patch to PerlDependencies.pm adding CGI::Compile Bug 20920: Add missing dependency on CGI::Compile Bug 20920: Followup: generated d/control |
Description
Jerome Charaoui
2018-06-12 15:22:55 UTC
Which versions of Debian and/or Ubuntu did you test? Debian 9.4 (stretch) libcgi-compile-perl is 'recommended' by libplack-perl, which gets it installed on most systems. Apparently koha depends on it. Not sure why it is only recommended by libplack-perl, but that's a different story.
The control file is not supposed to be patched, as stated in the file itself.
> # Do not manually edit "control"
CGI::Compile needs to be added to PerlDependencies.pm.
I will take care of updating the control file afterwards.
Created attachment 76217 [details] [review] bug 20920: patch to PerlDependencies.pm adding CGI::Compile Created attachment 76589 [details] [review] Bug 20920: Add missing dependency on CGI::Compile Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Created attachment 76590 [details] [review] Bug 20920: Followup: generated d/control Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Jerome, thanks a lot for spotting the problem and your patch! Minor QA change: first line of the commit message is supposed to be Bug xxxxx: Your bug report title I changed it and generated the new control file. Nick, please push, I will do a 18.05.01-2 and probably 17.11.07-2 package with this because it breaks fresh Koha with Plack on Stretch. Martin: is in 18.05.01-2, please push to 18.05.02. Fridolin: is in 17.11.07-2, please push to 17.11.08. Depends on 20693 for 17.11.x, please push the other one first. Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.02 Pushed to 17.11.x for 17.11.08 |