Summary: | If ISBN has 10 numbers only the first 9 numbers are used | ||
---|---|---|---|
Product: | Koha | Reporter: | Johan Larsson <johan.larsson> |
Component: | Acquisitions | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | critical | ||
Priority: | P5 - low | CC: | colin.campbell, fridolin.somers, jonathan.druart, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 7736 | ||
Bug Blocks: | |||
Attachments: |
Bug 20972: If ISBN has 10 numbers only the first 9 numbers are used
Signed off patch correcting ISBN extraction Add a test case for this to Ediorder.t Bug 20972: If ISBN has 10 numbers only the first 9 numbers are used Bug 20972: Add a testcase for bug 20972 |
Description
Johan Larsson
2018-06-21 08:44:32 UTC
Created attachment 76225 [details] [review] Bug 20972: If ISBN has 10 numbers only the first 9 numbers are used If ISBN has 10 numbers only the first 9 numbers are being added to the Edifact-message (PIA+5+3540556753:IB') This is caused by wrong positioning of capturing parentheses in a regular expression. Sponsored-by: Gothenburg University Library Created attachment 76281 [details] [review] Signed off patch correcting ISBN extraction Signed off patch Created attachment 76290 [details] [review] Add a test case for this to Ediorder.t Add a test for this bug and ensure routine is correctly distinguishing 10 character ISBNs from 13 digit EANs Thx for the quick sign-off and tests, Colin! Created attachment 76303 [details] [review] Bug 20972: If ISBN has 10 numbers only the first 9 numbers are used If ISBN has 10 numbers only the first 9 numbers are being added to the Edifact-message (PIA+5+3540556753:IB') This is caused by wrong positioning of capturing parentheses in a regular expression. Sponsored-by: Gothenburg University Library Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 76304 [details] [review] Bug 20972: Add a testcase for bug 20972 Ensure all 10 characters of ISBN are preserved And that ISBNs and EANs are correctly identidied in the PIA segment Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 18.11.x Pushed to 18.05.x for 18.05.02 Pushed to 17.11.x for 17.11.08 Regular expression are a curse, they can be hell or heaven :D Pushed to 17.05.x for 17.05.14 |