Summary: | Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | Templates | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | barton, fridolin.somers, jonathan.druart, martin.renvoize, nick, pierre-luc.lapointe |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 17893 | ||
Bug Blocks: | 20979 | ||
Attachments: |
Bug 20977: Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc
Bug 20977: Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc Bug 20977: Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc |
Description
Kyle M Hall (khall)
2018-06-21 15:11:11 UTC
Created attachment 76238 [details] [review] Bug 20977: Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc The naming mismatch can cause javascript errors. Test Plan: 1) Confirm the string vars used in catalog.js match the ones in catalog-strings.inc Created attachment 76582 [details] [review] Bug 20977: Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc The naming mismatch can cause javascript errors. Test Plan: 1) Confirm the string vars used in catalog.js match the ones in catalog-strings.inc Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe@inLibro.com> Created attachment 76607 [details] [review] Bug 20977: Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc The naming mismatch can cause javascript errors. Test Plan: 1) Confirm the string vars used in catalog.js match the ones in catalog-strings.inc Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.02 (In reply to Fridolin SOMERS from comment #6) > Depends on Bug 17893 not in 17.11.x This *is* broken in 17.11.x, do we need a separate patch for that? (In reply to Barton Chittenden from comment #7) > (In reply to Fridolin SOMERS from comment #6) > > Depends on Bug 17893 not in 17.11.x > > This *is* broken in 17.11.x, do we need a separate patch for that? Ok sorry, I will try to rebase (In reply to Fridolin SOMERS from comment #6) > Depends on Bug 17893 not in 17.11.x Ahhhh my mistake, Bug 17893 is in 17.11.x. Patch pushed to 17.11.x for v17.11.08. Depends on Bug 17893 not in 17.05.x |