Summary: | Error message when deleting bib attached to order | ||
---|---|---|---|
Product: | Koha | Reporter: | Donna <bwsdonna> |
Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | amitddng135, bwsdonna, fridolin.somers, jonathan.druart, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 17893, 20977 | ||
Bug Blocks: | |||
Attachments: |
Bug 20979: Fix confirm deletion popup when deleting a biblio
Bug 20979: Fix confirm deletion popup when deleting a biblio Bug 20979: Fix confirm deletion popup when deleting a biblio Bug 20979: Fix confirm deletion popup when deleting a biblio |
Description
Donna
2018-06-21 16:21:49 UTC
Created attachment 76248 [details] [review] Bug 20979: Fix confirm deletion popup when deleting a biblio When deleting an empty bib, error messages pops up "1 order(s) are using this record. You need order managing permissions to delete this record." even though user has superlibrarian permissions. Prevents the deletion of the bib record. I think ultimately we should do something more clever here, like checking if the orders have all been received or cancelled before complaining. But this is a bug fix and as such perfect. Created attachment 76777 [details] [review] Bug 20979: Fix confirm deletion popup when deleting a biblio When deleting an empty bib, error messages pops up "1 order(s) are using this record. You need order managing permissions to delete this record." even though user has superlibrarian permissions. Prevents the deletion of the bib record. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 76877 [details] [review] Bug 20979: Fix confirm deletion popup when deleting a biblio When deleting an empty bib, error messages pops up "1 order(s) are using this record. You need order managing permissions to delete this record." even though user has superlibrarian permissions. Prevents the deletion of the bib record. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 76878 [details] [review] Bug 20979: Fix confirm deletion popup when deleting a biblio When deleting an empty bib, error messages pops up "1 order(s) are using this record. You need order managing permissions to delete this record." even though user has superlibrarian permissions. Prevents the deletion of the bib record. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> A trivial patch, looks good and tests good. Passing QA. Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.02 Pushed to 17.11.x for 17.11.08 Depends on bug 20977 not in 17.05.x |