|
Description
Andrew Isherwood
2018-06-26 10:33:37 UTC
Created attachment 76431 [details] [review] Bug 20995: Add Request ID to table and request view This patch adds the display of Request ID to the OPAC views of all a user's requests and the individual request. To test: 1) Ensure you have ILL enabled 2) Log into the OPAC as a user with at least one request 3) Go to the "your interlibrary loan requests" page 4) TEST: Ensure that Request ID is displayed as the first column in the table 5) Click the "View" button on a request 6) TEST: Ensure that Request ID is displayed along with all the other request information Created attachment 79490 [details] [review] Bug 20995: Add Request ID to table and request view This patch adds the display of Request ID to the OPAC views of all a user's requests and the individual request. To test: 1) Ensure you have ILL enabled 2) Log into the OPAC as a user with at least one request 3) Go to the "your interlibrary loan requests" page 4) TEST: Ensure that Request ID is displayed as the first column in the table 5) Click the "View" button on a request 6) TEST: Ensure that Request ID is displayed along with all the other request information Signed-off-by: mmg@interleaf.ie Created attachment 80050 [details] [review] Bug 20995: Add Request ID to table and request view This patch adds the display of Request ID to the OPAC views of all a user's requests and the individual request. To test: 1) Ensure you have ILL enabled 2) Log into the OPAC as a user with at least one request 3) Go to the "your interlibrary loan requests" page 4) TEST: Ensure that Request ID is displayed as the first column in the table 5) Click the "View" button on a request 6) TEST: Ensure that Request ID is displayed along with all the other request information Signed-off-by: mmg@interleaf.ie Created attachment 80058 [details] [review] Bug 20995: Add Request ID to table and request view This patch adds the display of Request ID to the OPAC views of all a user's requests and the individual request. To test: 1) Ensure you have ILL enabled 2) Log into the OPAC as a user with at least one request 3) Go to the "your interlibrary loan requests" page 4) TEST: Ensure that Request ID is displayed as the first column in the table 5) Click the "View" button on a request 6) TEST: Ensure that Request ID is displayed along with all the other request information Signed-off-by: mmg@interleaf.ie Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 80059 [details] [review] Bug 20995: (QA follow-up) Add html filters and fix doubled up columns from merge Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 80069 [details] [review] Bug 20995: Add Request ID to table and request view This patch adds the display of Request ID to the OPAC views of all a user's requests and the individual request. To test: 1) Ensure you have ILL enabled 2) Log into the OPAC as a user with at least one request 3) Go to the "your interlibrary loan requests" page 4) TEST: Ensure that Request ID is displayed as the first column in the table 5) Click the "View" button on a request 6) TEST: Ensure that Request ID is displayed along with all the other request information Signed-off-by: mmg@interleaf.ie Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 80070 [details] [review] Bug 20995: (QA follow-up) Add html filters and fix doubled up columns from merge Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 80074 [details] [review] Bug 20995: Add Request ID to table and request view This patch adds the display of Request ID to the OPAC views of all a user's requests and the individual request. To test: 1) Ensure you have ILL enabled 2) Log into the OPAC as a user with at least one request 3) Go to the "your interlibrary loan requests" page 4) TEST: Ensure that Request ID is displayed as the first column in the table 5) Click the "View" button on a request 6) TEST: Ensure that Request ID is displayed along with all the other request information Signed-off-by: mmg@interleaf.ie Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 80075 [details] [review] Bug 20995: (QA follow-up) Add html filters and fix doubled up columns from merge Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Comment on attachment 80069 [details] [review] Bug 20995: Add Request ID to table and request view >From 9a31b446c429ee7d2b712631278870173ff58511 Mon Sep 17 00:00:00 2001 >From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> >Date: Tue, 26 Jun 2018 11:36:33 +0100 >Subject: [PATCH] Bug 20995: Add Request ID to table and request view > >This patch adds the display of Request ID to the OPAC views of all a >user's requests and the individual request. > >To test: > >1) Ensure you have ILL enabled >2) Log into the OPAC as a user with at least one request >3) Go to the "your interlibrary loan requests" page >4) TEST: Ensure that Request ID is displayed as the first column in the >table >5) Click the "View" button on a request >6) TEST: Ensure that Request ID is displayed along with all the other >request information > >Signed-off-by: mmg@interleaf.ie > >Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> >--- > .../bootstrap/en/modules/opac-illrequests.tt | 24 +++++++++++++++------- > 1 file changed, 17 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >index 838f827951..77fd1d0715 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >@@ -111,6 +111,7 @@ > <table id="illrequestlist" class="table table-bordered table-striped"> > <thead> > <tr> >+ <th>Request ID</th> > <th>Author</th> > <th>Title</th> > <th>Requested from</th> >@@ -125,13 +126,18 @@ > [% FOREACH request IN requests %] > [% status = request.status | html %] > <tr> >- <td>[% request.metadata.Author || 'N/A' | html %]</td> >- <td>[% request.metadata.Title || 'N/A' | html %]</td> >- <td>[% request.backend | html %]</td> >- <td>[% request.medium | html %]</td> >- <td>[% request.capabilities.$status.name | html %]</td> >- <td>[% request.placed | html %]</td> >- <td>[% request.updated | html %]</td> >+ <td>[% request.id %]</td> >+ <td> >+ [% IF request.metadata.Author %][% request.metadata.Author | html %][% ELSE %]<span>N/A</span>[% END %] >+ </td> >+ <td> >+ [% IF request.metadata.Title %][% request.metadata.Title | html %][% ELSE %]<span>N/A</span>[% END %] >+ </td> >+ <td>[% request.backend %]</td> >+ <td>[% request.medium %]</td> >+ <td>[% request.capabilities.$status.name %]</td> >+ <td>[% request.placed %]</td> >+ <td>[% request.updated %]</td> > <td> > <a href="/cgi-bin/koha/opac-illrequests.pl?method=view&illrequest_id=[% request.id | html %]" class="btn btn-default btn-small pull-right">View</a> > </td> >@@ -148,6 +154,10 @@ > <legend id="library_legend">Details from library</legend> > <ol> > <li> >+ <label for="request_id">Request ID:</label> >+ [% request.id %] >+ </li> >+ <li> > <label for="backend">Requested from:</label> > [% request.backend | html %] > </li> >-- >2.11.0 Comment on attachment 80070 [details] [review] Bug 20995: (QA follow-up) Add html filters and fix doubled up columns from merge >From 7cce8c2c0c31b2fd06edad8eedaa938d9c33195b Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer@bsz-bw.de> >Date: Fri, 5 Oct 2018 13:42:35 +0200 >Subject: [PATCH] Bug 20995: (QA follow-up) Add html filters and fix doubled up > columns from merge > >Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> >--- > .../opac-tmpl/bootstrap/en/modules/opac-illrequests.tt | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >index 77fd1d0715..0352ff5d65 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >@@ -126,18 +126,18 @@ > [% FOREACH request IN requests %] > [% status = request.status | html %] > <tr> >- <td>[% request.id %]</td> >+ <td>[% request.id | html %]</td> > <td> > [% IF request.metadata.Author %][% request.metadata.Author | html %][% ELSE %]<span>N/A</span>[% END %] > </td> > <td> > [% IF request.metadata.Title %][% request.metadata.Title | html %][% ELSE %]<span>N/A</span>[% END %] > </td> >- <td>[% request.backend %]</td> >- <td>[% request.medium %]</td> >- <td>[% request.capabilities.$status.name %]</td> >- <td>[% request.placed %]</td> >- <td>[% request.updated %]</td> >+ <td>[% request.backend | html %]</td> >+ <td>[% request.medium | html %]</td> >+ <td>[% request.capabilities.$status.name | html %]</td> >+ <td>[% request.placed | html %]</td> >+ <td>[% request.updated | html %]</td> > <td> > <a href="/cgi-bin/koha/opac-illrequests.pl?method=view&illrequest_id=[% request.id | html %]" class="btn btn-default btn-small pull-right">View</a> > </td> >@@ -155,7 +155,7 @@ > <ol> > <li> > <label for="request_id">Request ID:</label> >- [% request.id %] >+ [% request.id | html %] > </li> > <li> > <label for="backend">Requested from:</label> >-- >2.11.0 Comment on attachment 80059 [details] [review] Bug 20995: (QA follow-up) Add html filters and fix doubled up columns from merge >From d055ce19d6be1cb851628493af13606d3426ac39 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer@bsz-bw.de> >Date: Fri, 5 Oct 2018 13:42:35 +0200 >Subject: [PATCH] Bug 20995: (QA follow-up) Add html filters and fix doubled up > columns from merge > >Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >index 8442ac4..f1f8099 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >@@ -126,18 +126,13 @@ > [% FOREACH request IN requests %] > [% status = request.status | html %] > <tr> >- <td>[% request.id %]</td> >+ <td>[% request.id | html %]</td> > <td> > [% IF request.metadata.Author %][% request.metadata.Author | html %][% ELSE %]<span>N/A</span>[% END %] > </td> > <td> > [% IF request.metadata.Title %][% request.metadata.Title | html %][% ELSE %]<span>N/A</span>[% END %] > </td> >- <td>[% request.backend %]</td> >- <td>[% request.medium %]</td> >- <td>[% request.capabilities.$status.name %]</td> >- <td>[% request.placed %]</td> >- <td>[% request.updated %]</td> > <td>[% request.backend | html %]</td> > <td>[% request.medium | html %]</td> > <td>[% request.capabilities.$status.name | html %]</td> >@@ -160,7 +155,7 @@ > <ol> > <li> > <label for="request_id">Request ID:</label> >- [% request.id %] >+ [% request.id | html %] > </li> > <li> > <label for="backend">Requested from:</label> >-- >2.1.4 Created attachment 80727 [details] [review] Bug 20995: Add Request ID to table and request view Squashed for readability This patch adds the display of Request ID to the OPAC views of all a user's requests and the individual request. To test: 1) Ensure you have ILL enabled 2) Log into the OPAC as a user with at least one request 3) Go to the "your interlibrary loan requests" page 4) TEST: Ensure that Request ID is displayed as the first column in the table 5) Click the "View" button on a request 6) TEST: Ensure that Request ID is displayed along with all the other request information Signed-off-by: mmg@interleaf.ie Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 20995: (QA follow-up) Add html filters and fix doubled up columns from merge Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Awesome work all! Pushed to master for 18.11 The enhancement will not be backported to 18.05.x series. |