Summary: | Missing row/column defaults cause unexpected results in report wizards | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Reports | Assignee: | David Cook <dcook> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, dilan, fridolin.somers, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 21005: Missing row/column defaults cause unexpected results in report wizards
Bug 21005: Missing row/column defaults cause unexpected results in report wizards Bug 21005: Address QA tool failures on tabs Bug 21005: Missing row/column defaults cause unexpected results in report wizards Bug 21005: Address QA tool failures on tabs |
Description
David Cook
2018-06-27 00:18:05 UTC
I'm planning on fixing this one soon. Created attachment 77644 [details] [review] Bug 21005: Missing row/column defaults cause unexpected results in report wizards Some report wizards are missing row/column defaults, which sometimes return blank pages (borrowers_stats.pl) or results always equalling 0, which a non-discerning user may interpret incorrectly. If the DEBUG environmental variable is enabled, missing row/column choices will actually cause fatal software errors as well, which is also undesirable for users. This patch adds default choices for row and column on report wizards that had no radio buttons selected, so that a user can't submit the form without choosing a row and column. This prevents errors. To test: 1) Apply patch 2) Visit /cgi-bin/koha/reports/issues_avg_stats.pl 3) Visit /cgi-bin/koha/reports/borrowers_stats.pl 4) Visit /cgi-bin/koha/reports/catalogue_stats.pl 5) Visit /cgi-bin/koha/reports/issues_stats.pl 6) Observe that default choices for row/column are there Error results when applying patch: vagrant@kohadevbox:kohaclone(master)$ git bz apply -s 21005 Bug 21005 - Missing row/column defaults cause unexpected results in report wizards 77644 - Bug 21005: Missing row/column defaults cause unexpected results in report wizards Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21005: Missing row/column defaults cause unexpected results in report wizards Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt M koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt M koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt M koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt Failed to merge in the changes. Patch failed at 0001 Bug 21005: Missing row/column defaults cause unexpected results in report wizards The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21005-Missing-rowcolumn-defaults-cause-unexpec-XprggD.patch Created attachment 80686 [details] [review] Bug 21005: Missing row/column defaults cause unexpected results in report wizards Some report wizards are missing row/column defaults, which sometimes return blank pages (borrowers_stats.pl) or results always equalling 0, which a non-discerning user may interpret incorrectly. If the DEBUG environmental variable is enabled, missing row/column choices will actually cause fatal software errors as well, which is also undesirable for users. This patch adds default choices for row and column on report wizards that had no radio buttons selected, so that a user can't submit the form without choosing a row and column. This prevents errors. To test: 1) Apply patch 2) Visit /cgi-bin/koha/reports/issues_avg_stats.pl 3) Visit /cgi-bin/koha/reports/borrowers_stats.pl 4) Visit /cgi-bin/koha/reports/catalogue_stats.pl 5) Visit /cgi-bin/koha/reports/issues_stats.pl 6) Observe that default choices for row/column are there Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 80687 [details] [review] Bug 21005: Address QA tool failures on tabs Only whitespace changes. Created attachment 80740 [details] [review] Bug 21005: Missing row/column defaults cause unexpected results in report wizards Some report wizards are missing row/column defaults, which sometimes return blank pages (borrowers_stats.pl) or results always equalling 0, which a non-discerning user may interpret incorrectly. If the DEBUG environmental variable is enabled, missing row/column choices will actually cause fatal software errors as well, which is also undesirable for users. This patch adds default choices for row and column on report wizards that had no radio buttons selected, so that a user can't submit the form without choosing a row and column. This prevents errors. To test: 1) Apply patch 2) Visit /cgi-bin/koha/reports/issues_avg_stats.pl 3) Visit /cgi-bin/koha/reports/borrowers_stats.pl 4) Visit /cgi-bin/koha/reports/catalogue_stats.pl 5) Visit /cgi-bin/koha/reports/issues_stats.pl 6) Observe that default choices for row/column are there Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 80741 [details] [review] Bug 21005: Address QA tool failures on tabs Only whitespace changes. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.06 Pushed to 17.11.x for 17.11.13 *** Bug 3311 has been marked as a duplicate of this bug. *** |