| Summary: | Return branch not set for transfer when using SIP | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | SIP2 | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | colin.campbell, fridolin.somers, jonathan.druart, kyle, m.de.rooy, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 17680 | ||
| Bug Blocks: | 27166 | ||
| Attachments: |
Bug 21020: Fix return branch on transfer - SIP
Bug 21020: Fix return branch on transfer - SIP Bug 21020: Fix return branch on transfer - SIP Bug 21020: Fix return branch on transfer - SIP |
||
|
Description
Nick Clemens (kidclamp)
2018-06-29 12:58:30 UTC
Created attachment 76563 [details] [review] Bug 21020: Fix return branch on transfer - SIP Caused by commit 546379cc92b733cb29a0b70247a72c770afdad26 Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls Since this commit AddReturn return a Koha::Issue object, not a hashref with item's info. Test plan: ? Jonathan, shouldn't "$issue->issue->homebranch" be "$issue->item->homebranch"? Created attachment 76570 [details] [review] Bug 21020: Fix return branch on transfer - SIP Caused by commit 546379cc92b733cb29a0b70247a72c770afdad26 Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls Since this commit AddReturn return a Koha::Issue object, not a hashref with item's info. Test plan: ? (In reply to Kyle M Hall from comment #2) > Jonathan, shouldn't "$issue->issue->homebranch" be > "$issue->item->homebranch"? Whoops, yes of course! Thanks for catching that :) Created attachment 76574 [details] [review] Bug 21020: Fix return branch on transfer - SIP Caused by commit 546379cc92b733cb29a0b70247a72c770afdad26 Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls Since this commit AddReturn return a Koha::Issue object, not a hashref with item's info. Test plan: 1 - Enable SIP server on your test instance For kohadevbox: cp /etc/koha/SIPConfig.xml /etc/koha/sites/kohadev/ create patron with user/pass term1/term1 and grant circulation privileges 2 - enable AutomaticItemReturn 3 - Checkin an item which will generate a transfer via SIP2: perl /home/vagrant/kohaclone/misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l LPL --item {BARCODE} -m checkin -t CR 4 - Note no CT field 5 - Apply patch 6 - Repeate checkin via SIP2 7 - Transfer destination is correctly returned in CT Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 76716 [details] [review] Bug 21020: Fix return branch on transfer - SIP Caused by commit 546379cc92b733cb29a0b70247a72c770afdad26 Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls Since this commit AddReturn return a Koha::Issue object, not a hashref with item's info. Test plan: 1 - Enable SIP server on your test instance For kohadevbox: cp /etc/koha/SIPConfig.xml /etc/koha/sites/kohadev/ create patron with user/pass term1/term1 and grant circulation privileges 2 - enable AutomaticItemReturn 3 - Checkin an item which will generate a transfer via SIP2: perl /home/vagrant/kohaclone/misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l LPL --item {BARCODE} -m checkin -t CR 4 - Note no CT field 5 - Apply patch 6 - Repeate checkin via SIP2 7 - Transfer destination is correctly returned in CT Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.02 Pushed to 17.11.x for 17.11.08 Depends on Bug 17680 not in 17.05.x |