Summary: | JS error on search result breaks JS functionalities | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Staff interface | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | critical | ||
Priority: | P5 - low | CC: | gmcharlt, m.de.rooy, martin.renvoize, nick |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 20864 | ||
Bug Blocks: | |||
Attachments: |
Bug 21024: (bug 20864 follow-up) Only set bibs_selected cookie when BrowseResultSelection is activated
Revert "Bug 20864: Only set bibs_selected cookie when BrowseResultSelection is activated" Revert "Bug 20864: Only set bibs_selected cookie when BrowseResultSelection is activated" Revert "Bug 20864: Only set bibs_selected cookie when BrowseResultSelection is activated" |
Description
Jonathan Druart
2018-06-29 17:56:41 UTC
Created attachment 76579 [details] [review] Bug 21024: (bug 20864 follow-up) Only set bibs_selected cookie when BrowseResultSelection is activated This is an attempt to fix correctly the problem bug 20864 tried to solve. The cookie bibs_selected must only be defined if BrowseResultSelection is set. Bug 20864 removed the inclusion of commons.js, but some code from results.tt We should include it and take care of the pref in each function. Test plan: Retest 19290 and 20864 Created attachment 76583 [details] [review] Revert "Bug 20864: Only set bibs_selected cookie when BrowseResultSelection is activated" This reverts commit ce6ec1e7faef217950e3450788ea444dad26d7c0. It's too hard to get rid of the cookie. It is used for add to cart and list selection. The safer is to keep and use it, even if the pref is turned off. I've changed the documentation on the wiki - can you please check if it's correct now? https://wiki.koha-community.org/wiki/Use_of_Cookies Created attachment 76600 [details] [review] Revert "Bug 20864: Only set bibs_selected cookie when BrowseResultSelection is activated" This reverts commit ce6ec1e7faef217950e3450788ea444dad26d7c0. https://bugs.koha-community.org/show_bug.cgi?id=21024 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> (In reply to Katrin Fischer from comment #4) > I've changed the documentation on the wiki - can you please check if it's > correct now? https://wiki.koha-community.org/wiki/Use_of_Cookies It's used to add records to a list as well. (In reply to Jonathan Druart from comment #6) > (In reply to Katrin Fischer from comment #4) > > I've changed the documentation on the wiki - can you please check if it's > > correct now? https://wiki.koha-community.org/wiki/Use_of_Cookies > > It's used to add records to a list as well. Updated the cookie documentation, thx! Created attachment 76714 [details] [review] Revert "Bug 20864: Only set bibs_selected cookie when BrowseResultSelection is activated" This reverts commit ce6ec1e7faef217950e3450788ea444dad26d7c0. https://bugs.koha-community.org/show_bug.cgi?id=21024 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Awesome work all! Pushed to master for 18.11 Also reverted in 18.05.x for 18.05.02. |