Summary: | Koha::Patron::Discharge is missing use C4::Letters | ||
---|---|---|---|
Product: | Koha | Reporter: | Charles Farmer <charles.farmer> |
Component: | Patrons | Assignee: | Charles Farmer <charles.farmer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, kyle.m.hall, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug21025: Add GetPreparedLetter to Koha::Patron::Discharge
Bug 21025: Add GetPreparedLetter to Koha::Patron::Discharge Bug 21025: Add GetPreparedLetter to Koha::Patron::Discharge |
Description
Charles Farmer
2018-06-29 20:03:38 UTC
Created attachment 76588 [details] [review] Bug21025: Add GetPreparedLetter to Koha::Patron::Discharge Test plan (shamelessly ripped from Bug20953): 1) Set system preference 'useDischarge' to 'Allow' 2) Choose a patron without checkouts nor fines nor restrictions 3) Log at OPAC and go to patron page /cgi-bin/koha/opac-user.pl 4) Click on 'ask for a discharge' tab => You see /cgi-bin/koha/opac-discharge.pl with text 'What is a discharge? ...' 5) Click on 'Ask for a discharge' link => You see /cgi-bin/koha/opac-discharge.pl?op=request with text 'Your discharge request has been sent ...' 6) In a new browser tab/page, go to intranet on /cgi-bin/koha/members/discharges.pl => You see one discharge requets for the patron => Click on 'allow' on patron discharge request 7) Come back to OPAC and refresh /cgi-bin/koha/opac-discharge.pl => You see link 'Get your discharge' 8) Click on the link to get your generated PDF => An error message should appear informing you to contact your website's admin 9) Apply this patch 10) Click again on the link to get your generated PDF => This time, a download prompt should appear Can't reproduce the problem, but we have seen similar recently and this will not hurt. Please don't forget to assign bugs to yourself when providing or planning to provide a patch! Created attachment 76761 [details] [review] Bug 21025: Add GetPreparedLetter to Koha::Patron::Discharge Test plan (shamelessly ripped from Bug20953): 1) Set system preference 'useDischarge' to 'Allow' 2) Choose a patron without checkouts nor fines nor restrictions 3) Log at OPAC and go to patron page /cgi-bin/koha/opac-user.pl 4) Click on 'ask for a discharge' tab => You see /cgi-bin/koha/opac-discharge.pl with text 'What is a discharge? ...' 5) Click on 'Ask for a discharge' link => You see /cgi-bin/koha/opac-discharge.pl?op=request with text 'Your discharge request has been sent ...' 6) In a new browser tab/page, go to intranet on /cgi-bin/koha/members/discharges.pl => You see one discharge requets for the patron => Click on 'allow' on patron discharge request 7) Come back to OPAC and refresh /cgi-bin/koha/opac-discharge.pl => You see link 'Get your discharge' 8) Click on the link to get your generated PDF => An error message should appear informing you to contact your website's admin 9) Apply this patch 10) Click again on the link to get your generated PDF => This time, a download prompt should appear Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 76897 [details] [review] Bug 21025: Add GetPreparedLetter to Koha::Patron::Discharge Test plan (shamelessly ripped from Bug20953): 1) Set system preference 'useDischarge' to 'Allow' 2) Choose a patron without checkouts nor fines nor restrictions 3) Log at OPAC and go to patron page /cgi-bin/koha/opac-user.pl 4) Click on 'ask for a discharge' tab => You see /cgi-bin/koha/opac-discharge.pl with text 'What is a discharge? ...' 5) Click on 'Ask for a discharge' link => You see /cgi-bin/koha/opac-discharge.pl?op=request with text 'Your discharge request has been sent ...' 6) In a new browser tab/page, go to intranet on /cgi-bin/koha/members/discharges.pl => You see one discharge requets for the patron => Click on 'allow' on patron discharge request 7) Come back to OPAC and refresh /cgi-bin/koha/opac-discharge.pl => You see link 'Get your discharge' 8) Click on the link to get your generated PDF => An error message should appear informing you to contact your website's admin 9) Apply this patch 10) Click again on the link to get your generated PDF => This time, a download prompt should appear Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.02 Pushed to 17.11.x for 17.11.09 |