Summary: | Totals in statistics tab change when StatisticsFields is changed | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | christian.stelzenmueller, fridolin.somers, gmcharlt, jonathan.druart, kyle.m.hall, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.03,18.11.09
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 9939 | ||
Attachments: |
statistics tab
current checkouts Bug 21027; Fix checkout statistics if 1+ of the fields is not defined Screenshot_total_checkouts without patch Bug 21027; Fix checkout statistics if 1+ of the fields is not defined Bug 21027: Fix checkout statistics if 1+ of the fields is not defined |
Description
Katrin Fischer
2018-07-02 14:56:00 UTC
Screenshots? Which values are different? - Use a patron who hasn't checked out items before - Set StatisticsFields to itype|ccode - Check out some items without location - Verify that statistics stable shows the correct number of checkouts - Check out one item with a location or just change one of your checked out items - Verify the total is still correct - Change StatisticsFields to location|itype|ccode - Verify the total has changed now - it's only 1 (the one with a location) I retested it on master... not quite the same result as last time, but still something strange going on here. Hope the test plan works for you. Created attachment 76874 [details]
statistics tab
Created attachment 76875 [details]
current checkouts
For the screenshot the pref was set to location|itype|ccode. If location is removed, the number of checkouts shows as 2 (which is correct). Note: in the screenshot, the shelving location is also not shown? Created attachment 88990 [details] [review] Bug 21027; Fix checkout statistics if 1+ of the fields is not defined Hi Katrin, I think this patch fixes the problem you faced. I did not read a test plan as I have to admit I completely forgot about that code and not sure how the changes could be completely tested. Created attachment 89008 [details]
Screenshot_total_checkouts without patch
Created attachment 91455 [details] [review] Bug 21027; Fix checkout statistics if 1+ of the fields is not defined TEST - Use a patron who hasn't checked out items before - Set StatisticsFields to itype|ccode - Check out some items without location - Verify that statistics stable shows the correct number of checkouts - Check out one item with a location or just change one of your checked out items - Verify the total is still correct - Change StatisticsFields to location|itype|ccode - Verify the total has changed now - it's only 1 (the one with a location) Apply the patch and try again Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 91472 [details] [review] Bug 21027: Fix checkout statistics if 1+ of the fields is not defined TEST - Use a patron who hasn't checked out items before - Set StatisticsFields to itype|ccode - Check out some items without location - Verify that statistics stable shows the correct number of checkouts - Check out one item with a location or just change one of your checked out items - Verify the total is still correct - Change StatisticsFields to location|itype|ccode - Verify the total has changed now - it's only 1 (the one with a location) Apply the patch and try again Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.03 backported to 18.11.x for 18.11.09 |