Bug 21038

Summary:	Reserves should be holds
Product:	Koha	Reporter:	Katrin Fischer <katrin.fischer>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	trivial
Priority:	P5 - low	CC:	fridolin.somers, martin.renvoize, nick
Version:	Main	Keywords:	Academy
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	String patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 21038: Reserves should be holds Bug 21038: Reserves should be holds

Description Katrin Fischer 2018-07-04 20:21:32 UTC

When moderating a discharge request from the discharge tab in the patron's account in staff, existing holds will trigger a message:

Borrower has reserves

Reserves should be holds to match terminology used in Koha.

Comment 1 Owen Leonard 2018-07-16 18:44:36 UTC

Created attachment 77021 [details] [review]
Bug 21038: Reserves should be holds

This patch corrects the text of the warning about discharges cancelling
holds.

To test, apply the patch and view the discharge for a patron who has
holds:

 - "Borrower" is changed to "patron"
 - "reserves" is changed to "holds"
 - "canceled" (18 instances in the templates) is changed to "cancelled"
   (51 instances).

Comment 2 Katrin Fischer 2018-07-16 20:20:00 UTC

Created attachment 77023 [details] [review]
Bug 21038: Reserves should be holds

This patch corrects the text of the warning about discharges cancelling
holds.

To test, apply the patch and view the discharge for a patron who has
holds:

 - "Borrower" is changed to "patron"
 - "reserves" is changed to "holds"
 - "canceled" (18 instances in the templates) is changed to "cancelled"
   (51 instances).

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 3 Katrin Fischer 2018-07-16 20:20:24 UTC

String change, moving to PQA directly.

Comment 4 Nick Clemens (kidclamp) 2018-07-18 19:18:06 UTC

Awesome work all!

Pushed to master for 18.11

Comment 5 Martin Renvoize (ashimema) 2018-08-02 11:45:44 UTC

Pushed to 18.05.x for 18.05.03

Comment 6 Fridolin Somers 2018-10-08 05:51:23 UTC

Pushed to 17.11.x for 17.11.11