Bug 21047

Summary: Wrong koha to marc mapping on bibliosubtitle in SQL files
Product: Koha Reporter: Fridolin Somers <fridolin.somers>
Component: MARC Bibliographic data supportAssignee: Fridolin Somers <fridolin.somers>
Status: Failed QA --- QA Contact: Marcel de Rooy <m.de.rooy>
Severity: minor    
Priority: P5 - low CC: m.de.rooy, nick
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 21047: Remove koha to marc mapping on bibliosubtitle in SQL files
Bug 21047: Remove koha to marc mapping on bibliosubtitle in SQL files
Bug 21047: Remove koha to marc mapping on bibliosubtitle in SQL files

Description Fridolin Somers 2018-07-06 14:32:06 UTC
SQL files in installer/data/mysql/ create frameworks with a koha to MARC mapping on obsolete table bibliosubtitle.
This table was removed when upgrading from Koha 2.2 to 3.0.
Comment 1 Fridolin Somers 2018-07-06 14:35:03 UTC
Created attachment 76738 [details] [review]
Bug 21047: Remove koha to marc mapping on bibliosubtitle in SQL files

SQL files in installer/data/mysql/ create frameworks with a koha to MARC mapping on obsolete table bibliosubtitle.
This table was removed when upgrading from Koha 2.2 to 3.0.

Test plan :
1) Create a new install with web installer
2) Check that creating a record is OK
Comment 2 Katrin Fischer 2018-07-08 15:33:42 UTC
Created attachment 76763 [details] [review]
Bug 21047: Remove koha to marc mapping on bibliosubtitle in SQL files

SQL files in installer/data/mysql/ create frameworks with a koha to MARC mapping on obsolete table bibliosubtitle.
This table was removed when upgrading from Koha 2.2 to 3.0.

Test plan :
1) Create a new install with web installer
2) Check that creating a record is OK

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 3 Katrin Fischer 2018-07-08 15:34:22 UTC
I think it would be good to also add a database update cleaning up existing frameworks. What do you think, Frido?
Comment 4 Marcel de Rooy 2018-07-09 09:49:29 UTC
Created attachment 76780 [details] [review]
Bug 21047: Remove koha to marc mapping on bibliosubtitle in SQL files

SQL files in installer/data/mysql/ create frameworks with a koha to MARC mapping on obsolete table bibliosubtitle.
This table was removed when upgrading from Koha 2.2 to 3.0.

Test plan :
1) Create a new install with web installer
2) Check that creating a record is OK

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Nick Clemens (kidclamp) 2018-07-12 14:43:21 UTC
I agree with Cait, we need an update here - frameworks with the wrong code cannot be edited (the koha field cannot anyways)
Comment 6 Fridolin Somers 2020-03-24 14:29:44 UTC
Now that there is Bug 11529 do we replace instead of removing ?
Comment 7 Katrin Fischer 2020-03-24 14:39:45 UTC
(In reply to Fridolin SOMERS from comment #6)
> Now that there is Bug 11529 do we replace instead of removing ?

I think the bug took care of that already - and if you do it for existing installations, it will be incomplete - only new/edited will fill the column. 

I think it would still be worthwhile to remove the false mapping, if there are any left.