Bug 21054

Summary: Extra closing body tag in sco-main.tt prevents slip printing
Product: Koha Reporter: Nick Clemens <nick>
Component: Self checkoutAssignee: Nick Clemens <nick>
Status: Pushed to Stable --- QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: katrin.fischer, martin.renvoize
Version: master   
Hardware: All   
OS: All   
Whiteboard:
Change sponsored?: --- Patch complexity: Trivial patch
Bot Control: --- When did the bot last check this:
Who signed the patch off: Text to go in the release notes:
Bug Depends on: 16732    
Bug Blocks:    
Attachments: Bug 21054: Remove extraneous </body> tag from sco-main.tt
Bug 21054: Remove extraneous </body> tag from sco-main.tt

Description Nick Clemens 2018-07-09 13:24:34 UTC
Bug 16732 added an extra closing body tag to sco-main.tt 

Bug 18387 notes that page errors kick the SCO user out.

The extra body tag creates an html error and prevents receipt printing
Comment 1 Nick Clemens 2018-07-09 13:26:48 UTC
Created attachment 76793 [details] [review]
Bug 21054: Remove extraneous </body> tag from sco-main.tt

To test:
1 - Enable sco and setup AutoSelfCheck
2 - Try to use self checkout and print receipt
3 - You shoudl be redirected to the login page
4 - Apply patch and restart all the things
5 - Try to use self checkout and print a receipt
6 - Success!
Comment 2 Martin Renvoize 2018-07-12 10:01:31 UTC
Created attachment 76880 [details] [review]
Bug 21054: Remove extraneous </body> tag from sco-main.tt

To test:
1 - Enable sco and setup AutoSelfCheck
2 - Try to use self checkout and print receipt
3 - You shoudl be redirected to the login page
4 - Apply patch and restart all the things
5 - Try to use self checkout and print a receipt
6 - Success!

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize 2018-07-12 10:01:59 UTC
Very trivial fix, works as expected, Signing Off.
Comment 4 Martin Renvoize 2018-07-12 10:19:52 UTC
So trivial I've decided to just pass qa directly.
Comment 5 Nick Clemens 2018-07-13 11:27:12 UTC
Awesome work all!

Pushed to master for 18.11
Comment 6 Martin Renvoize 2018-07-15 18:42:08 UTC
Pushed to 18.05.x for 18.05.02