Summary: | Changing the logged in library can fail sporadically | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | Architecture, internals, and plumbing | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, george, jonathan.druart, martin.renvoize, nick |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Patch
Bug 21056: Changing the logged in library can fail sporadically Bug 21056: Add another flush later |
Description
Kyle M Hall (khall)
2018-07-09 18:04:53 UTC
Created attachment 76800 [details] [review] Patch What is the value of SessionStorage? From CGI::Session: """ Always explicitly calling flush() on the session before the program exits is recommended. For extra safety, call it immediately after every important session update. """ Maybe we should add this line below (there is another ->param call later). It sounds like we should put some flush call to C4::Auth as well. (In reply to Jonathan Druart from comment #2) > What is the value of SessionStorage? > > From CGI::Session: > """ > Always explicitly calling flush() on the session before the program exits is > recommended. For extra safety, call it immediately after every important > session update. > """ > > Maybe we should add this line below (there is another ->param call later). > > It sounds like we should put some flush call to C4::Auth as well. I certainly wouldn't hurt! Do you want to just add that as a followup here, or do you want to file a separate bug? Tested on the NEKLS test server - works as expected Created attachment 77336 [details] [review] Bug 21056: Changing the logged in library can fail sporadically We are getting reports that sometimes changing the logged in library via selectbranchprinter.pl sometimes appears to fail. Flushing the session after updating the branch appears to fix this. Test Plan: 1) Change your logged in library repeatedly. Hopefully ( sort of ) it will fail to change. You may want to try various browsers. 2) Apply this patch 3) Note the change no longer fails Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 77337 [details] [review] Bug 21056: Add another flush later Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (In reply to Jonathan Druart from comment #2) > It sounds like we should put some flush call to C4::Auth as well. No bug reported, so no fix for now. Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.03 Pushed to 17.11.x for 17.11.10 |