Bug 21064

Summary: Advanced cataloging editor - rancor - check for changes should return 'undefined' instead of 'undef'
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: CatalogingAssignee: Nick Clemens (kidclamp) <nick>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, m.de.rooy, martin.renvoize, pierre-luc.lapointe
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 19267    
Bug Blocks:    
Attachments: Bug 21064: Use undefined instead of undef
Bug 21064: Use undefined instead of undef
Bug 21064: Use undefined instead of undef

Description Nick Clemens (kidclamp) 2018-07-12 10:17:50 UTC
undef causes a JS error, undefined seems to be the correct term to use
Comment 1 Nick Clemens (kidclamp) 2018-07-12 10:19:57 UTC
Created attachment 76882 [details] [review]
Bug 21064: Use undefined instead of undef

To test:
1 - Load the advanced cataloging editor
2 - Refresh the page several times
3 - Check the JS console, you shoudl see an error:
    'undef is not defined'
4 - Apply patch
5 - Try again, should be no error
Comment 2 Pierre-Luc Lapointe 2018-07-13 19:28:20 UTC
Created attachment 76963 [details] [review]
Bug 21064: Use undefined instead of undef

To test:
1 - Load the advanced cataloging editor
2 - Refresh the page several times
3 - Check the JS console, you shoudl see an error:
    'undef is not defined'
4 - Apply patch
5 - Try again, should be no error

Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe@inLibro.com>
Comment 3 Katrin Fischer 2018-07-18 06:07:36 UTC
Created attachment 77065 [details] [review]
Bug 21064: Use undefined instead of undef

To test:
1 - Load the advanced cataloging editor
2 - Refresh the page several times
3 - Check the JS console, you shoudl see an error:
    'undef is not defined'
4 - Apply patch
5 - Try again, should be no error

Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe@inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Nick Clemens (kidclamp) 2018-07-19 17:37:31 UTC
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize (ashimema) 2018-08-02 13:45:38 UTC
Pushed to 18.05.x for 18.05.03
Comment 6 Fridolin Somers 2018-09-21 09:33:13 UTC
Pushed to 17.11.x for 17.11.10