Summary: | Javascript error on article requests page | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Hold requests | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 21389 | ||
Attachments: |
Bug 21076: Don't call autocomplete code after patron found
Bug 21076: Don't call autocomplete code after patron found Bug 21076: Don't call autocomplete code after patron found |
Description
Nick Clemens (kidclamp)
2018-07-13 17:49:01 UTC
Created attachment 76959 [details] [review] Bug 21076: Don't call autocomplete code after patron found To test: 1 - Enable article requests 2 - Search on staff client 3 - Click 'Request article' 4 - Find a patron 5 - View error in console 6 - Apply patch 7 - Reload 8 - Not error is gone Created attachment 76962 [details] [review] Bug 21076: Don't call autocomplete code after patron found To test: 1 - Enable article requests 2 - Search on staff client 3 - Click 'Request article' 4 - Find a patron 5 - View error in console 6 - Apply patch 7 - Reload 8 - Not error is gone Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and it works. Created attachment 77063 [details] [review] Bug 21076: Don't call autocomplete code after patron found To test: 1 - Enable article requests 2 - Search on staff client 3 - Click 'Request article' 4 - Find a patron 5 - View error in console 6 - Apply patch 7 - Reload 8 - Not error is gone Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and it works. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> This fixes the JavaScript error, but I noticed a little difference to how the search on the hold page works: When you click the autocomplete result, it translates to the cardnumber and you have to search again - for holds you are immediately forwarded to the record. Maybe something for a future bug. Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.03 Pushed to 17.11.x for 17.11.10 |