| Summary: | Overdrive JS breaks when window opened from another site | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | OPAC | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | bibliwho, fridolin.somers, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 22602 | ||
| Attachments: |
Bug 21078: ovedrive.js Catch error if window.opener is not accessible
Bug 21078: ovedrive.js Catch error if window.opener is not accessible Bug 21078: overdrive.js Catch error if window.opener is not accessible |
||
|
Description
Nick Clemens (kidclamp)
2018-07-14 14:29:49 UTC
Created attachment 76965 [details] [review] Bug 21078: ovedrive.js Catch error if window.opener is not accessible To Test: 0 - Enable overdrive search results on your koha 1 - From an source develop a link to your koha instance that opens a new window: <a target="_blank" href="http://localhost:8080/cgi-bin/koha/opac-search.pl?q=love">Test</a> 2 - Click that link 3 - Note Overdrive results do not load 4 - Note error in JS console 5 - Apply patch 6 - Click the link again 7 - Note OD results load 8 - Note no error in console Created attachment 79327 [details] [review] Bug 21078: ovedrive.js Catch error if window.opener is not accessible To Test: 0 - Enable overdrive search results on your koha 1 - From an source develop a link to your koha instance that opens a new window: <a target="_blank" href="http://localhost:8080/cgi-bin/koha/opac-search.pl?q=love">Test</a> 2 - Click that link 3 - Note Overdrive results do not load 4 - Note error in JS console 5 - Apply patch 6 - Click the link again 7 - Note OD results load 8 - Note no error in console Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Works as expected, Signing off. Created attachment 79544 [details] [review] Bug 21078: overdrive.js Catch error if window.opener is not accessible To Test: 0 - Enable overdrive search results on your koha 1 - From a source develop a link to your koha instance that opens a new window: <a target="_blank" href="http://localhost:8080/cgi-bin/koha/opac-search.pl?q=love">Test</a> 2 - Click that link 3 - Note Overdrive results do not load 4 - Note error in JS console 5 - Apply patch 6 - Click the link again 7 - Note OD results load 8 - Note no error in console Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.05 Pushed to 17.11.x for 17.11.11 |