| Summary: | Missing optgroup closing tag in orderreceive.tt | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Cook <dcook> |
| Component: | Acquisitions | Assignee: | David Cook <dcook> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, martin.renvoize, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 21097 - Missing optgroup closing tag in orderreceive.tt
Bug 21097 - Missing optgroup closing tag in orderreceive.tt Bug 21097: Missing optgroup closing tag in orderreceive.tt |
||
|
Description
David Cook
2018-07-20 08:01:04 UTC
Created attachment 77152 [details] [review] Bug 21097 - Missing optgroup closing tag in orderreceive.tt There is a missing optgroup closing tag in orderreceive.tt. It doesn't actually cause any display issues (at least in modern browsers), but it's invalid markup, so this patch fixes it. _TEST PLAN_ 0. Add a budget and add a fund 1. Add a vendor 2. Add a basket 3. Add an order to a basket 4. Close the basket 5. Receive the order 6. Make sure the budget and fund both display when selecting the fund Created attachment 77157 [details] [review] Bug 21097 - Missing optgroup closing tag in orderreceive.tt There is a missing optgroup closing tag in orderreceive.tt. It doesn't actually cause any display issues (at least in modern browsers), but it's invalid markup, so this patch fixes it. _TEST PLAN_ 0. Add a budget and add a fund 1. Add a vendor 2. Add a basket 3. Add an order to a basket 4. Close the basket 5. Receive the order 6. Make sure the budget and fund both display when selecting the fund Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Going straight to Passed QA as it's such a trivial patch and it tests as it should :) Please read https://wiki.koha-community.org/wiki/Commit_messages#Examples Then use the QA script to catch such errors. Created attachment 77162 [details] [review] Bug 21097: Missing optgroup closing tag in orderreceive.tt There is a missing optgroup closing tag in orderreceive.tt. It doesn't actually cause any display issues (at least in modern browsers), but it's invalid markup, so this patch fixes it. _TEST PLAN_ 0. Add a budget and add a fund 1. Add a vendor 2. Add a basket 3. Add an order to a basket 4. Close the basket 5. Receive the order 6. Make sure the budget and fund both display when selecting the fund Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Grr.. I ran the qa script but entirely missed the bad commit message line :(.. Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.03 Pushed to 17.11.x for 17.11.10 |