Summary: | Re-indent staff client cart template | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, katrin.fischer, martin.renvoize, nick, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 21112: Re-indent staff client cart template
Bug 21112: Re-indent staff client cart template Bug 21112: Re-indent staff client cart template |
Description
Owen Leonard
2018-07-24 16:09:58 UTC
Created attachment 77239 [details] [review] Bug 21112: Re-indent staff client cart template This patch reindents the template for the staff client cart, basket.tt - Trailing spaces removed - Indentation changed to a consistent 4 spaces - Markup indentation made more consistent To test, apply the patch and add multiple items to the cart in the staff client. View the cart and confirm that it looks as it should both in the "brief" and "more details" views. HTML validation before and after the patch should return the same results. Created attachment 77257 [details] [review] Bug 21112: Re-indent staff client cart template This patch reindents the template for the staff client cart, basket.tt - Trailing spaces removed - Indentation changed to a consistent 4 spaces - Markup indentation made more consistent To test, apply the patch and add multiple items to the cart in the staff client. View the cart and confirm that it looks as it should both in the "brief" and "more details" views. HTML validation before and after the patch should return the same results. Signed-off-by: DEVINIM <kohadevinim@devinim.com.tr> Hi Devinim, don't forget to change the status to "signed off" :) Created attachment 77417 [details] [review] Bug 21112: Re-indent staff client cart template This patch reindents the template for the staff client cart, basket.tt - Trailing spaces removed - Indentation changed to a consistent 4 spaces - Markup indentation made more consistent To test, apply the patch and add multiple items to the cart in the staff client. View the cart and confirm that it looks as it should both in the "brief" and "more details" views. HTML validation before and after the patch should return the same results. Signed-off-by: DEVINIM <kohadevinim@devinim.com.tr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.03. Although this is technically an enhancement, there are no visible effects and backporting now whilst there are no other changes in this template in the 18.05.x branch means future backports of bugfixes based upon it should be more seamless. I prefer not to push to 17.11.x |