Summary: | New syspref to allow hiding of private patron data in circulation page | ||
---|---|---|---|
Product: | Koha | Reporter: | Alex Buckley <alexbuckley> |
Component: | Circulation | Assignee: | Alex Buckley <alexbuckley> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, gmcharlt, jonathan.druart, katrin.fischer, kyle.m.hall, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34979 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
Sponsored by: Toi Ohomai Institute of Technology in New Zealand and Catalyst IT.
|
Version(s) released in: | |
Bug Depends on: | |||
Bug Blocks: | 21815 | ||
Attachments: |
Bug 21121 - Added new system preference to control hiding of personal patron information in the circulation page
Bug 21121: Added new system preference to control hiding of personal patron information in the circulation page Bug 21121: Added new system preference to control hiding of personal patron information in the circulation page Bug 21121: Add the IGNORE clause |
Description
Alex Buckley
2018-07-26 01:57:07 UTC
Created attachment 77276 [details] [review] Bug 21121 - Added new system preference to control hiding of personal patron information in the circulation page Libraries may want to hide personal patron data from the circulation page for privacy reasons this syspref introduces that ability for library staff to control the display of this data themselves without having to ask support vendors to hide it for them. Test plan: 1. View circulation page and input a patrons barcode or name 2. Notice if the patron has a phone number, email, street address and city set then these are displayed in the left hand side of the screen under the patrons name. Otherwise if all/any of these fields are not set for the patron then the text: "No <datafield> stored." is displayed. 3. Apply this patch 4. Run ./updatedatabase.pl from the Koha shell to run the atomicupdate 5. Restart memcached and plack 6. Notice a new systempreference named 'HidePersonalPatronDetailOnCirculation' has been added, which has the default value 'Dont' 7. Without changing the default value notice the personal patron information is still displayed on the circulation page 8. Change the value of the syspref to 'Do' and now notice the phone number, email address, street address and city are now hidden in the circulation page Sponsored-By: Catalyst IT Created attachment 77280 [details] [review] Bug 21121: Added new system preference to control hiding of personal patron information in the circulation page Libraries may want to hide personal patron data from the circulation page for privacy reasons this syspref introduces that ability for library staff to control the display of this data themselves without having to ask support vendors to hide it for them. Test plan: 1. View circulation page and input a patrons barcode or name 2. Notice if the patron has a phone number, email, street address and city set then these are displayed in the left hand side of the screen under the patrons name. Otherwise if all/any of these fields are not set for the patron then the text: "No <datafield> stored." is displayed. 3. Apply this patch 4. Run ./updatedatabase.pl from the Koha shell to run the atomicupdate 5. Restart memcached and plack 6. Notice a new systempreference named 'HidePersonalPatronDetailOnCirculation' has been added, which has the default value 'Dont' 7. Without changing the default value notice the personal patron information is still displayed on the circulation page 8. Change the value of the syspref to 'Do' and now notice the phone number, email address, street address and city are now hidden in the circulation page Sponsored-By: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 77367 [details] [review] Bug 21121: Added new system preference to control hiding of personal patron information in the circulation page Libraries may want to hide personal patron data from the circulation page for privacy reasons this syspref introduces that ability for library staff to control the display of this data themselves without having to ask support vendors to hide it for them. Test plan: 1. View circulation page and input a patrons barcode or name 2. Notice if the patron has a phone number, email, street address and city set then these are displayed in the left hand side of the screen under the patrons name. Otherwise if all/any of these fields are not set for the patron then the text: "No <datafield> stored." is displayed. 3. Apply this patch 4. Run ./updatedatabase.pl from the Koha shell to run the atomicupdate 5. Restart memcached and plack 6. Notice a new systempreference named 'HidePersonalPatronDetailOnCirculation' has been added, which has the default value 'Dont' 7. Without changing the default value notice the personal patron information is still displayed on the circulation page 8. Change the value of the syspref to 'Do' and now notice the phone number, email address, street address and city are now hidden in the circulation page Sponsored-By: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 77368 [details] [review] Bug 21121: Add the IGNORE clause Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Awesome work all! Pushed to master for 18.11 Enhancement, currently will not be backported to 18.05.x series. Just a note to say this was sponsored-by: Toi Ohomai Institute of Technology in New Zealand and Catalyst IT. Added to the 'Text to go in the release notes' box for you Alex Thanks Martin! Is it relevant to have HidePatronName and this new pref HidePersonalPatronDetailOnCirculation? Should not we merge them? Not a bad catch there Jonathan... it would be nice to reduce the number of sysprefs.. perhaps an enhancement that allowed selection of which fields to show rather than a hard-coded list is in order. (In reply to Jonathan Druart from comment #10) > Is it relevant to have HidePatronName and this new pref > HidePersonalPatronDetailOnCirculation? Should not we merge them? I think HidePatronName is for hiding patron information outside circulation, while the other targets pages in the circulation module specifically. Something more general would still be nice, but I think both make sense right now. |