|
Description
David Bourgault
2018-07-27 21:13:11 UTC
Created attachment 77321 [details] [review] Bug 21130: Prevent HTML class from being translated Adds a xsl:value-of tag to prevent the value from being translated. TEST PLAN 0) Apply patch 1) Translate 2) In the opac, div.record has not changed NOTE: I don't know if this bug affects all translations, I noticed it when translating to fr-CA. The fix will work for all languages. Created attachment 78566 [details] [review] Bug 21130: (Follow up OPAC Results) Prevent HTML class from being translated This fixes the same issue where "title" is being translated (in fr-CA at least) and thus break the javascript impacting the result display in the OPAC Created attachment 79058 [details] [review] Bug 21130: (Follow up OPAC Results) Prevent HTML class from being translated This fixes the same issue where "title" is being translated (in fr-CA at least) and thus break the javascript impacting the result display in the OPAC Created attachment 79110 [details] [review] Bug 21130: (Follow up OPAC Results) Prevent HTML class from being translated This fixes the same issue where "title" is being translated (in fr-CA at least) and thus break the javascript impacting the result display in the OPAC (In reply to David Bourgault from comment #1) > 1) Translate Please elaborate this more for testers unfamiliar with the translation process. I tried to figure something out, but I couldn't test this, because when I ran the translation scripts on master and patched, I got the same po files. Examine opac-tmrpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl around line 110 (just below the "Wrapper div" comment. You'll find <xsl:attribute name="class">record</xsl:attribute> Translate, then look at the (fr-CA) version, you'll find <xsl:attribute name="class">notice</xsl:attribute> This will in turn create in the webpage some <div class="notice" instead of <div class="record" Bad. And yes, David's steps were... hum... lacking? (In reply to Blou from comment #6) > Examine opac-tmrpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl around line > 110 (just below the "Wrapper div" comment. You'll find > > <xsl:attribute name="class">record</xsl:attribute> > > Translate, then look at the (fr-CA) version, you'll find Translate how? You did not give the steps. > > <xsl:attribute name="class">notice</xsl:attribute> > > This will in turn create in the webpage some <div class="notice" instead of > <div class="record" > > Bad. Imagine I only how how to click and type. Tell me more detailed instructions starting from: 1) vagrant up jessie 2) cd kohaclone 3) git checkout -b bug_21130 origin/master 3a) Oops... forgot to do the opac steps first to find the page that is broken. 3b) something about looking for something on a page where it is going to be wrong. 4) git bz apply 21130 5) restart_all 6) sudo service apache2 restart 7) sudo systemctl daemon-reload 8) kshell 9) cd misc/translator 10) ./translate --help -- I'm stuck. 11) open the opac 12) change language -- oops... forgot to set some system preferences, but I'm playing ignorant, so I'm stuck, because there is no way to change anything. 13) inspect the page source -- looking for something gives me the line that should be corrected now. I need more details. I can fill in some of them, but this doesn't give me enough information to test still. Imagine the person is trying to set up Koha for the first time. Write instructions. Created attachment 86421 [details] [review] Bug 21130: (Follow up OPAC Results) Prevent HTML class from being translated This fixes the same issue where "title" is being translated (in fr-CA at least) and thus break the javascript impacting the result display in the OPAC Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Created attachment 86886 [details] [review] Bug 21130: Prevent HTML class from being translated Adds a xsl:value-of tag to prevent the value from being translated. TEST PLAN 0) Apply patch 1) Translate 2) In the opac, div.record has not changed NOTE: I don't know if this bug affects all translations, I noticed it when translating to fr-CA. The fix will work for all languages. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 86887 [details] [review] Bug 21130: (Follow up OPAC Results) Prevent HTML class from being translated This fixes the same issue where "title" is being translated (in fr-CA at least) and thus break the javascript impacting the result display in the OPAC Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.04 backported to 18.05.x for 18.05.12 |