Summary: | Batch item/record modification/deletion tools does not open uploaded files in utf-8 | ||
---|---|---|---|
Product: | Koha | Reporter: | Victor Grousset/tuxayo <victor> |
Component: | Tools | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21141 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Numbers without BOM
Numbers with BOM Bug 21142: Open uploaded files in utf-8 - batch mod/del Bug 21142: Open uploaded files in utf-8 - batch mod/del Bug 21142: Open uploaded files in utf-8 - batch mod/del |
Description
Victor Grousset/tuxayo
2018-08-01 19:52:59 UTC
Created attachment 77406 [details]
Numbers without BOM
Created attachment 77407 [details]
Numbers with BOM
I'm not sure to work on this. Anyone can feel free to take it. It is just a display problem, right? Created attachment 77986 [details] [review] Bug 21142: Open uploaded files in utf-8 - batch mod/del Batch item/record modification/deletion tools does not open uploaded files in utf-8 Test plan: Edit and delete records and items using a file which will contain: valid and invalid barcodes with and without utf-8 chars ([U+1F495]) You should see the warning message: "The *** 39999000[U+1F495]001679 does not exist in the database." Created attachment 77992 [details] [review] Bug 21142: Open uploaded files in utf-8 - batch mod/del Batch item/record modification/deletion tools does not open uploaded files in utf-8 Test plan: Edit and delete records and items using a file which will contain: valid and invalid barcodes with and without utf-8 chars ([U+1F495]) You should see the warning message: "The *** 39999000[U+1F495]001679 does not exist in the database." Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 78015 [details] [review] Bug 21142: Open uploaded files in utf-8 - batch mod/del Batch item/record modification/deletion tools does not open uploaded files in utf-8 Test plan: Edit and delete records and items using a file which will contain: valid and invalid barcodes with and without utf-8 chars ([U+1F495]) You should see the warning message: "The *** 39999000[U+1F495]001679 does not exist in the database." Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Awesome work all! Pushed to master for 18.11 Thanks for the fix! [U+1F495][U+1F495][U+1F495] (In reply to Jonathan Druart from comment #4) > It is just a display problem, right? Actually jes and no, because with the BOM test case, it's still there (invisible instead of being mojibake[1]) And when using itemnumbers it's not just a display problem, it will make the first itemnumber invalid. For some reason, with barcodes it works; there must be some code that cleans the beginning and the end of the line. [1] https://en.wikipedia.org/wiki/Mojibake Pushed to 18.05.x for 18.05.03 Pushed to 17.11.x for 17.11.10 |