Bug 21149

Summary: Administrator creation in onboarding always fails
Product: Koha Reporter: Owen Leonard <oleonard>
Component: Installation and upgrade (web-based installer)Assignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Martin Renvoize <martin.renvoize>
Severity: blocker    
Priority: P5 - low CC: gmcharlt, jonathan.druart, martin.renvoize, nick
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 20287    
Bug Blocks:    
Attachments: Bug 21149: Fix superlibrarian creation in onboarding
Bug 21149: Fix superlibrarian creation in onboarding
Bug 21149: Fix superlibrarian creation in onboarding

Description Owen Leonard 2018-08-02 14:34:20 UTC
During the onboarding process in installation, the creation of an Administrator patron always fails with the error, "The patron has not been created! Cardnumber or Userid may already exist."

git bisect blames Bug 20287: Move AddMember to Koha::Patron->store
Comment 1 Jonathan Druart 2018-08-02 14:51:31 UTC
Created attachment 77447 [details] [review]
Bug 21149: Fix superlibrarian creation in onboarding

See bug 21087 for more details.

Test plan:
Drop your DB
Start the installation process
Use the onboarding process to install missing data
The superlibrarian created during this process should be created
sucessfully and allowed to login
Comment 2 Jonathan Druart 2018-08-02 14:52:24 UTC
I wrote bug 19185 to catch issues during the install/onboarding process
Comment 3 Owen Leonard 2018-08-02 16:09:02 UTC
Created attachment 77450 [details] [review]
Bug 21149: Fix superlibrarian creation in onboarding

See bug 21087 for more details.

Test plan:
Drop your DB
Start the installation process
Use the onboarding process to install missing data
The superlibrarian created during this process should be created
sucessfully and allowed to login

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Martin Renvoize 2018-08-03 21:11:24 UTC
Created attachment 77485 [details] [review]
Bug 21149: Fix superlibrarian creation in onboarding

See bug 21087 for more details.

Test plan:
Drop your DB
Start the installation process
Use the onboarding process to install missing data
The superlibrarian created during this process should be created
sucessfully and allowed to login

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2018-08-03 21:12:54 UTC
Works as expected and no failures on the qa scripts. Looks good to me, Passing QA
Comment 6 Martin Renvoize 2018-08-03 21:51:49 UTC
I have the selenium tests bug and it's dependency of the separate db's for testing on my list for early next week.  Lets get some tests in place to prevent a re-occurrence :)
Comment 7 Nick Clemens 2018-08-08 21:34:26 UTC
Awesome work all!

Pushed to master for 18.11
Comment 8 Martin Renvoize 2018-08-09 10:04:46 UTC
Depends on (and is caused by) but 20287 which is not in 18.05.x series.