| Summary: | Warnings in MARCdetail.pl - isn't numeric in numeric eq (==) | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | aleisha, dcook, fridolin.somers, lucas, martin.renvoize, nick, pierre-marc.thibault, tomascohen |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 21170 Remove "isn't numeric in numeric eq (==)" warnings in MARCdetail
Bug 21170 Remove "isn't numeric in numeric eq (==)" warnings in MARCdetail Bug 21170: Remove "isn't numeric in numeric eq (==)" warnings in MARCdetail |
||
|
Description
Jonathan Druart
2018-08-07 19:28:11 UTC
Created attachment 83303 [details] [review] Bug 21170 Remove "isn't numeric in numeric eq (==)" warnings in MARCdetail Easily removed switching the two conditions. Test plan: Hit catalogue/MARCdetail.pl?biblionumber=1 => Without this patch you will see in the log warnings like Argument "ddc" isn't numeric in numeric eq (==) at /home/vagrant/kohaclone/catalogue/MARCdetail.pl line 277. => With this patch applied the warnings do no longer appear Created attachment 83471 [details] [review] Bug 21170 Remove "isn't numeric in numeric eq (==)" warnings in MARCdetail Easily removed switching the two conditions. Test plan: Hit catalogue/MARCdetail.pl?biblionumber=1 => Without this patch you will see in the log warnings like Argument "ddc" isn't numeric in numeric eq (==) at /home/vagrant/kohaclone/catalogue/MARCdetail.pl line 277. => With this patch applied the warnings do no longer appear Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Created attachment 84190 [details] [review] Bug 21170: Remove "isn't numeric in numeric eq (==)" warnings in MARCdetail Easily removed switching the two conditions. Test plan: Hit catalogue/MARCdetail.pl?biblionumber=1 => Without this patch you will see in the log warnings like Argument "ddc" isn't numeric in numeric eq (==) at /home/vagrant/kohaclone/catalogue/MARCdetail.pl line 277. => With this patch applied the warnings do no longer appear Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.03 pushed to 18.05.x for 18.05.09 Pushed to 17.11.x for 17.11.15 |