| Summary: | decreaseLoanHighHolds does not properly calculate date when TimeFormat set to 12 hour | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kyle.m.hall, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 21176: Fix due date calculation when high holds and TimeFormat is 12hr
Bug 21176: Fix due date calculation when high holds and TimeFormat is 12hr Bug 21176: Fix due date calculation when high holds and TimeFormat is 12hr |
||
|
Description
Nick Clemens (kidclamp)
2018-08-08 11:51:24 UTC
Created attachment 77761 [details] [review] Bug 21176: Fix due date calculation when high holds and TimeFormat is 12hr What we were doing was wrong and is still wrong. The output_pref should not be done in modules or script, only template side. Much more work would be needed to clean the situation. This patch provides less changes as possible to, hopefully, not introduce side-effects. To recreate: 1 - Enable decreaseLoanHighHolds, set to 1 day and more than 0 holds 2 - Set TimeFormat to 12 hour 3 - Find or create a record with two items 4 - Place a hold on one of them 5 - Checkout the other to a different patron 6 - Note the warning message display correct time 7 - Confirm the checkout 8 - Note the item is due at 11:59AM Created attachment 79326 [details] [review] Bug 21176: Fix due date calculation when high holds and TimeFormat is 12hr What we were doing was wrong and is still wrong. The output_pref should not be done in modules or script, only template side. Much more work would be needed to clean the situation. This patch provides less changes as possible to, hopefully, not introduce side-effects. To recreate: 1 - Enable decreaseLoanHighHolds, set to 1 day and more than 0 holds 2 - Set TimeFormat to 12 hour 3 - Find or create a record with two items 4 - Place a hold on one of them 5 - Checkout the other to a different patron 6 - Note the warning message display correct time 7 - Confirm the checkout 8 - Note the item is due at 11:59AM Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> I agree with Jonathan that it would be better to fix this more thoroughly but that the patch is pragmatic and it resolves the problem for now. Signing off. Created attachment 79788 [details] [review] Bug 21176: Fix due date calculation when high holds and TimeFormat is 12hr What we were doing was wrong and is still wrong. The output_pref should not be done in modules or script, only template side. Much more work would be needed to clean the situation. This patch provides less changes as possible to, hopefully, not introduce side-effects. To recreate: 1 - Enable decreaseLoanHighHolds, set to 1 day and more than 0 holds 2 - Set TimeFormat to 12 hour 3 - Find or create a record with two items 4 - Place a hold on one of them 5 - Checkout the other to a different patron 6 - Note the warning message display correct time 7 - Confirm the checkout 8 - Note the item is due at 11:59AM Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.05 Pushed to 17.11.x for 17.11.11 |