Bug 21182

Summary: acqui/check_duplicate_barcode_ajax.pl is not longer in use
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: fridolin.somers, katrin.fischer, martin.renvoize, nick
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 6963, 7178    
Bug Blocks: 21183    
Attachments: Bug 21182: Remove acqui/check_duplicate_barcode_ajax.pl
Bug 21182: Remove acqui/check_duplicate_barcode_ajax.pl

Description Jonathan Druart 2018-08-08 17:57:06 UTC
It has been added by
  commit 327be442bd6e63e5ff8c0a5e2461ae836e8deffb
  Bug 6963: Corrects a problem when a new order is created with a duplicate barcode.

But its last call removed since:
  commit eefc774e274ce8167f1063be5f9204a0d5cf5650
  Bug 7178: Acquisition item creation improvement
Comment 1 Jonathan Druart 2018-08-08 17:58:53 UTC
Created attachment 77583 [details] [review]
Bug 21182: Remove acqui/check_duplicate_barcode_ajax.pl

It has been added by
  commit 327be442bd6e63e5ff8c0a5e2461ae836e8deffb
  Bug 6963: Corrects a problem when a new order is created with a duplicate barcode.

But its last call removed since:
  commit eefc774e274ce8167f1063be5f9204a0d5cf5650
  Bug 7178: Acquisition item creation improvement

Test plan:
  git grep check_duplicate_barcode
should not return anything
Comment 2 Martin Renvoize 2018-08-09 15:11:05 UTC
Created attachment 77629 [details] [review]
Bug 21182: Remove acqui/check_duplicate_barcode_ajax.pl

It has been added by
  commit 327be442bd6e63e5ff8c0a5e2461ae836e8deffb
  Bug 6963: Corrects a problem when a new order is created with a duplicate barcode.

But its last call removed since:
  commit eefc774e274ce8167f1063be5f9204a0d5cf5650
  Bug 7178: Acquisition item creation improvement

Test plan:
  git grep check_duplicate_barcode
should not return anything

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize 2018-08-09 15:12:17 UTC
Verified I can't find any uses of this at all before the patch and the reasoning is clear from Jonathans comments and the git logs. 

Verified the patch works as expected.

Going straight to Passed QA.
Comment 4 Nick Clemens 2018-08-22 15:02:20 UTC
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize 2018-08-24 12:37:30 UTC
Pushed to 18.05.x for 18.05.03.
Comment 6 Fridolin Somers 2018-09-21 14:00:56 UTC
I prefer not to push to 17.11.x