Bug 21202

Summary: C4::Items - Remove GetItemsByBiblioitemnumber
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, m.de.rooy, martin.renvoize, nick
Version: unspecified   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 21203    
Bug Blocks: 18252, 21205    
Attachments: Bug 21202: Replace C4::Items::GetItemsByBiblioitemnumber calls
Bug 21202: Replace C4::Items::GetItemsByBiblioitemnumber calls
Bug 21202: Replace C4::Items::GetItemsByBiblioitemnumber calls
Bug 21202: Replace C4::Items::GetItemsByBiblioitemnumber calls

Description Jonathan Druart 2018-08-10 15:07:09 UTC
my $items = GetItemsByBiblioitemnumber($biblioitemnumber);
will become
  my $items = $biblio->items->unblessed;
Comment 1 Jonathan Druart 2018-08-10 16:15:35 UTC
Created attachment 77703 [details] [review]
Bug 21202: Replace C4::Items::GetItemsByBiblioitemnumber calls

http://lists.koha-community.org/pipermail/koha-devel/2018-August/044757.html

Prior to this patch, GetRecords returned timestampX, cardX and borrowerX for
the last 3 patrons who checked out the items.

I have no idea if it is a desired effects but, as this code has been
there for a very long time (2005), I suspect it's not.
The "doc" (/ilsdi.pl?service=Describe&verb=GetRecords) does not say
anything about the checkouts info.

Test plan:
hit /ilsdi.pl?service=GetRecords&id=1
and confirm the info about items are displayed correctly
Comment 2 Josef Moravec 2018-08-16 10:33:32 UTC
Created attachment 77888 [details] [review]
Bug 21202: Replace C4::Items::GetItemsByBiblioitemnumber calls

http://lists.koha-community.org/pipermail/koha-devel/2018-August/044757.html

Prior to this patch, GetRecords returned timestampX, cardX and borrowerX for
the last 3 patrons who checked out the items.

I have no idea if it is a desired effects but, as this code has been
there for a very long time (2005), I suspect it's not.
The "doc" (/ilsdi.pl?service=Describe&verb=GetRecords) does not say
anything about the checkouts info.

Test plan:
hit /ilsdi.pl?service=GetRecords&id=1
and confirm the info about items are displayed correctly

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 3 Jonathan Druart 2018-08-22 00:56:31 UTC
Created attachment 78079 [details] [review]
Bug 21202: Replace C4::Items::GetItemsByBiblioitemnumber calls

http://lists.koha-community.org/pipermail/koha-devel/2018-August/044757.html

Prior to this patch, GetRecords returned timestampX, cardX and borrowerX for
the last 3 patrons who checked out the items.

I have no idea if it is a desired effects but, as this code has been
there for a very long time (2005), I suspect it's not.
The "doc" (/ilsdi.pl?service=Describe&verb=GetRecords) does not say
anything about the checkouts info.

Test plan:
hit /ilsdi.pl?service=GetRecords&id=1
and confirm the info about items are displayed correctly
Comment 4 Marcel de Rooy 2018-08-24 06:42:00 UTC
QA: Looking here
Comment 5 Marcel de Rooy 2018-08-24 06:56:21 UTC
Created attachment 78108 [details] [review]
Bug 21202: Replace C4::Items::GetItemsByBiblioitemnumber calls

http://lists.koha-community.org/pipermail/koha-devel/2018-August/044757.html

Prior to this patch, GetRecords returned timestampX, cardX and borrowerX for
the last 3 patrons who checked out the items.

I have no idea if it is a desired effects but, as this code has been
there for a very long time (2005), I suspect it's not.
The "doc" (/ilsdi.pl?service=Describe&verb=GetRecords) does not say
anything about the checkouts info.

Test plan:
hit /ilsdi.pl?service=GetRecords&id=1
and confirm the info about items are displayed correctly

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Nick Clemens (kidclamp) 2018-08-31 13:00:00 UTC
Awesome work all!

Pushed to master for 18.11
Comment 7 Martin Renvoize (ashimema) 2018-09-05 12:53:44 UTC
Refactoring enhancement, deprecation warning added to the affected subroutine to warn users of the pending changes to ILS-DI created by this change.

Deprecation warning will be in 18.05.04
Comment 8 Fridolin Somers 2018-09-24 09:22:12 UTC
Refactoring enhancement not pushed to 17.11.x
Comment 9 Jonathan Druart 2019-03-14 18:00:52 UTC
*** Bug 18253 has been marked as a duplicate of this bug. ***