Bug 21211

Hi,
there is no description for this bug report and there is not enough information in the subject to see what it's about. Can you please add some more details?

(In reply to Katrin Fischer from comment #1)
> Hi,
> there is no description for this bug report and there is not enough
> information in the subject to see what it's about. Can you please add some
> more details?

Hi, sorry we never meant to leave it that way! It's a case of clicking too quickly and then not having time to go back to it straightaway. In the process of adding the details now. Thanks, Aude

Description: messages/notes on Patrons do not appear in a consistent way across all the Patron tabs, depending on how they are created.

Add Message via button - only appears on the Checkout page.
Add new message via link on checkout page - this also displays in the Circulation Note field in the Details page but is clear from Checkout page too.

Could messages be made to appear on both the Details and the Checkout tabs, please, regardless of the way they are created?

(In reply to information from comment #3)

> Add Message via button - only appears on the Checkout page.

This should not be the case. The button is in an include file which is used across all patron-specific pages. If you find otherwise it's a bug (which I don't see in our installation of 17.11).

> Add new message via link on checkout page - this also displays in the
> Circulation Note field in the Details page but is clear from Checkout page
> too.

I don't really understand this comment, but I do see inconsistency between the way the "Add a new message" link appears on the circulation page versus the detail page: The link appears on Circulation when there are no messages and doesn't on the detail page. I consider it a bug that the link appears on circulation when there are no messages.

It looks like purchase suggestions, ill requests and discharges are missing the patron toolbar.

Also the modification logs - but as this template is used in 2 places, there might be a reason for it.

I am going to use this bug to fix the toolbar, which will make the "Add message" show more consistently.

For the different display of notes I have filed a new bug:
Bug 25188 - Circulation notes only displays on checkouts tab, but not on details

Created attachment 103209 [details] [review]
Bug 21211: Add patron toolbar to suggestions, discharges and ill requests tabs

When paging through the patron account in staff, using the tabs on
the right, you notice that some pages are missing the patron toolbar
on top and that the headings, where they exist, vary in size.

This patch adds the patron toolbar to 3 more tabs and changes headings
to h1 to be consistent with older tabs. It has also been suggested on
another tab that this is preferrable for screen readers.

Note: Modification log was left out for now, as this is also used in tools.

To test:
- Activate ILL (ILLModule pref)
- Activate discharges (UseDischarge pref)
- Go to any patron account, tab through the tabs...
- Verify that discharge, purchase suggestions and ill requests are
  missing the toolbar
- Apply patch
- Verify that the toolbar now appears on these pages and works
  correctly
- Also veriy that the headings are now consistently h1 on all pages

Created attachment 103211 [details] [review]
Bug 21211: Add patron toolbar to suggestions, discharges and ill requests tabs

When paging through the patron account in staff, using the tabs on
the right, you notice that some pages are missing the patron toolbar
on top and that the headings, where they exist, vary in size.

This patch adds the patron toolbar to 3 more tabs and changes headings
to h1 to be consistent with older tabs. It has also been suggested on
another tab that this is preferrable for screen readers.

Note: Modification log was left out for now, as this is also used in tools.

To test:
- Activate ILL (ILLModule pref)
- Activate discharges (UseDischarge pref)
- Go to any patron account, tab through the tabs...
- Verify that discharge, purchase suggestions and ill requests are
  missing the toolbar
- Apply patch
- Verify that the toolbar now appears on these pages and works
  correctly
- Also veriy that the headings are now consistently h1 on all pages

Created attachment 103218 [details] [review]
Bug 21211: Add patron toolbar to suggestions, discharges and ill requests tabs

When paging through the patron account in staff, using the tabs on
the right, you notice that some pages are missing the patron toolbar
on top and that the headings, where they exist, vary in size.

This patch adds the patron toolbar to 3 more tabs and changes headings
to h1 to be consistent with older tabs. It has also been suggested on
another tab that this is preferrable for screen readers.

Note: Modification log was left out for now, as this is also used in tools.

To test:
- Activate ILL (ILLModule pref)
- Activate discharges (UseDischarge pref)
- Go to any patron account, tab through the tabs...
- Verify that discharge, purchase suggestions and ill requests are
  missing the toolbar
- Apply patch
- Verify that the toolbar now appears on these pages and works
  correctly
- Also veriy that the headings are now consistently h1 on all pages

Signed-off-by: David Roberts <david@koha-ptfs.co.uk>

Created attachment 103258 [details] [review]
Bug 21211: Add patron toolbar to suggestions, discharges and ill requests tabs

When paging through the patron account in staff, using the tabs on
the right, you notice that some pages are missing the patron toolbar
on top and that the headings, where they exist, vary in size.

This patch adds the patron toolbar to 3 more tabs and changes headings
to h1 to be consistent with older tabs. It has also been suggested on
another tab that this is preferrable for screen readers.

Note: Modification log was left out for now, as this is also used in tools.

To test:
- Activate ILL (ILLModule pref)
- Activate discharges (UseDischarge pref)
- Go to any patron account, tab through the tabs...
- Verify that discharge, purchase suggestions and ill requests are
  missing the toolbar
- Apply patch
- Verify that the toolbar now appears on these pages and works
  correctly
- Also veriy that the headings are now consistently h1 on all pages

Signed-off-by: David Roberts <david@koha-ptfs.co.uk>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Nice work everyone!

Pushed to master for 20.05

Backported to 19.11.x for 19.11.06

backported to 19.05.x for 19.05.11