| Summary: | NULL values in updated_on field break the Patrons REST API | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Pete Edwards <koha> |
| Component: | REST API | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED INVALID | QA Contact: | |
| Severity: | major | ||
| Priority: | P5 - low | CC: | jonathan.druart, m.de.rooy, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17651 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21402 |
||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
|
Description
Pete Edwards
2018-08-14 14:28:19 UTC
I looked at all the branches down to 16.05.x and they all seem to have NOT NULL on the table definition. Maybe this is an update process bug. I did wonder whether it could be an update issue but I couldn't find any evidence of a script that would have set a value on the column for existing records when the column was added. Does simply changing the column definition to "NOT NULL" cause the default timestamp to be set - if so I really don't understand why it was created with "NULL". Obviously, this leaves me concerned that there could be other other discrepancies - is there an easy way to compare my actual schema to the one the should be installed - I installed v18.05 but my database has the column defined as: `updated_on` timestamp NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, Thanks (In reply to Pete Edwards from comment #2) > I installed v18.05 but my database has the column > defined as: > > `updated_on` timestamp NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE > CURRENT_TIMESTAMP, borrowers.updated_on has been added by bug 10459, and it was already NOT NULL. Did you mean you did a fresh 18.05(.00?) install and you got this table definition? |