Summary: | Remove our .clearfix class in favor of Bootstrap's | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
Severity: | minor | ||
Priority: | P5 - low | CC: | jonathan.druart, josef.moravec, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 21239 | ||
Attachments: |
Bug 21234: Remove our .clearfix class in favor of Bootstrap's
Bug 21234: Remove our .clearfix class in favor of Bootstrap's Bug 21234: Remove our .clearfix class in favor of Bootstrap's |
Description
Owen Leonard
2018-08-16 13:01:40 UTC
Created attachment 77922 [details] [review] Bug 21234: Remove our .clearfix class in favor of Bootstrap's This patch removes the ".clearfix" declaration from staff-global.scss so that Bootstrap's built-in clearfix class will be used. To reproduce this issue, see Administration -> Currencies and exchange rates. The table of currencies does not appear below the table buttons. Apply the patch and regenerate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear the browser cache if necessary and reload the Currencies and exchange rates page. The table should appear in the correct position. Created attachment 77976 [details] [review] Bug 21234: Remove our .clearfix class in favor of Bootstrap's This patch removes the ".clearfix" declaration from staff-global.scss so that Bootstrap's built-in clearfix class will be used. To reproduce this issue, see Administration -> Currencies and exchange rates. The table of currencies does not appear below the table buttons. Apply the patch and regenerate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear the browser cache if necessary and reload the Currencies and exchange rates page. The table should appear in the correct position. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 78047 [details] [review] Bug 21234: Remove our .clearfix class in favor of Bootstrap's This patch removes the ".clearfix" declaration from staff-global.scss so that Bootstrap's built-in clearfix class will be used. To reproduce this issue, see Administration -> Currencies and exchange rates. The table of currencies does not appear below the table buttons. Apply the patch and regenerate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear the browser cache if necessary and reload the Currencies and exchange rates page. The table should appear in the correct position. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Awesome work all! Pushed to master for 18.11 |