| Summary: | Remove services_throttle if not required for ThingISBN | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Web services | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 21226 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 21226: Remove table services_throttle
Bug 21235: Remove table services_throttle Bug 21235: Remove table services_throttle Bug 21235: Remove table services_throttle Bug 21235: (qa followup) Remove table services_throttle Bug 21235: Remove table services_throttle Bug 21235: (QA follow-up) Remove table services_throttle |
||
|
Description
Martin Renvoize (ashimema)
2018-08-16 13:08:44 UTC
Created attachment 77920 [details] [review] Bug 21226: Remove table services_throttle This table was only used by XISBN, this patch remove the table and the related code (cronjobs) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 77921 [details] [review] Bug 21235: Remove table services_throttle This table was only used by XISBN, this patch remove the table and the related code (cronjobs) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Blocked, waiting for an answer from ThingISBN's guys. I've had nothing back from the LibraryThing people (reached out on twitter and email). As such, I think we're safe to remove this now. Setting to 'signed off' as the patches were already signed off in the original bug before my QA. I'll qa them shortly. Created attachment 78502 [details] [review] Bug 21235: Remove table services_throttle This table was only used by XISBN, this patch remove the table and the related code (cronjobs) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> https://bugs.koha-community.org/show_bug.cgi?id=21235 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Passing QA Created attachment 78531 [details] [review] Bug 21235: Remove table services_throttle This table was only used by XISBN, this patch remove the table and the related code (cronjobs) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> https://bugs.koha-community.org/show_bug.cgi?id=21235 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 78532 [details] [review] Bug 21235: (qa followup) Remove table services_throttle Add the missing db update to nuke the services throttle from high orbit Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 78533 [details] [review] Bug 21235: Remove table services_throttle This table was only used by XISBN, this patch remove the table and the related code (cronjobs) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> https://bugs.koha-community.org/show_bug.cgi?id=21235 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 78534 [details] [review] Bug 21235: (QA follow-up) Remove table services_throttle Add the missing db update to nuke the services throttle from high orbit Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Added a followup with the missing atomic update to remove existing services_throttle table for upgrades Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.04 I prefer not to push to 17.11.x to keep this change in a major upgrade |